Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acs: Pass granule delegation cases #135

Merged
merged 6 commits into from
Aug 7, 2023
Merged

acs: Pass granule delegation cases #135

merged 6 commits into from
Aug 7, 2023

Conversation

bitboom
Copy link
Collaborator

@bitboom bitboom commented Aug 2, 2023 •
edited
Loading

This PR covers negative TCs related RMI_GRANULE_DELEGATE.

Changes

  1. Change GranuleState to Delegated with PA translated by IPA given RMI
  2. Handle RMI_ERROR_INPUT according to RMM Spec
  3. Set granule state only when un/delegation succeed

Negative cases

idx type addr
1 ADDR_UNALIGNED 0x88300001
2 ADDR_DEV_MEM_MMIO 0x1C0B0000
3 ADDR_OUTSIDE_OF_PERITTED_PA 0x1000000001000
4 ADDR_DELEGATED 0x8830C000
5 ADDR_REC 0x88315000
6 ADDR_DATA 0x88348000
7 ADDR_RTT 0x88306000
8 ADDR_RD 88303000
9 ADDR_PAS_REALM 8834E000
10 ADDR_PAS_SECURE 6000000

@bitboom bitboom marked this pull request as draft August 2, 2023 07:19
@bitboom
rmi: Fix GRANULE_UN/DELEGATE's return according to spec
b04487e 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
rmi: rsi: Fix logging to cover error cases
e9e206f 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
Delete an unused file
e120f4f 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
Set granule state only when un/delegation succeed
01e9a45 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
rmi: Fix DATA_DESTROY to set Delegated with PA
8375de4 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
rmm: Validate address before requesting un/delegation
b33e843 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom bitboom marked this pull request as ready for review August 3, 2023 05:07
@bitboom bitboom self-assigned this Aug 3, 2023
@bitboom bitboom mentioned this pull request Aug 3, 2023
Open
@bitboom bitboom merged commit a7b12b7 into main Aug 7, 2023
4 of 5 checks passed
@bitboom bitboom deleted the acs-granule-del branch August 7, 2023 02:17
@bitboom bitboom changed the title acs: Pass granule delegation case acs: Pass granule delegation cases Aug 17, 2023
@bitboom bitboom mentioned this pull request Aug 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpzigi754 zpzigi754 zpzigi754 approved these changes

@bokdeuk-jeong bokdeuk-jeong bokdeuk-jeong approved these changes

@jinbpark jinbpark jinbpark approved these changes

@hihi-wang hihi-wang Awaiting requested review from hihi-wang

Assignees

@bitboom bitboom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bitboom @zpzigi754 @bokdeuk-jeong @jinbpark