Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acs: Pass whole realm activate cases & some data creation cases #183

Merged
merged 3 commits into from
Sep 18, 2023
Merged

acs: Pass whole realm activate cases & some data creation cases #183

merged 3 commits into from
Sep 18, 2023

Conversation

bitboom
Copy link
Collaborator

@bitboom bitboom commented Sep 15, 2023 •
edited
Loading

This PR passes whole realm activate cases & some data creation cases.
The rest of data creation cases are related with RTT walk.
@zpzigi754 is fixing about RTT walk now, so I will re-visit after his work :)

The main patches of this PR are two

  • Validate whether IPA, passed by host, is in PAR.
    • Because IPA of Realm should be in PAR(Protected Address Range)
  • Implement REALM_ACTIVATE

zpzigi754
zpzigi754 reviewed Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@zpzigi754 zpzigi754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor]
there is a typo in git commit message
obtion -> option

@bitboom bitboom marked this pull request as ready for review September 18, 2023 05:09
@bitboom
Copy link
Collaborator Author

bitboom commented Sep 18, 2023

[minor] there is a typo in git commit message obtion -> option

Thanks! I fixed it.

bokdeuk-jeong
bokdeuk-jeong reviewed Sep 18, 2023
View reviewed changes
rmm/src/rmi/rtt.rs Show resolved Hide resolved
rmm/src/rmi/rtt.rs Outdated Show resolved Hide resolved
@bitboom
rmm: Validate whether IPA is in PAR
06d0996 
IPA of Realm should be in PAR(Protected Address Range)

Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
rmm: Implement REALM_ACTIVATE
b844b29 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
@bitboom
scripts: Add ACS to clean option
208e5d8 
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
zpzigi754
zpzigi754 reviewed Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@zpzigi754 zpzigi754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to add ipa validation and realm activate!

rmm/src/rmi/rtt.rs Show resolved Hide resolved
bokdeuk-jeong
bokdeuk-jeong approved these changes Sep 18, 2023
View reviewed changes
rmm/src/rmi/rtt.rs Show resolved Hide resolved
@bitboom bitboom merged commit 903fa9a into main Sep 18, 2023
6 checks passed
@bitboom bitboom deleted the acs-act branch September 18, 2023 09:40
@bitboom bitboom mentioned this pull request Sep 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpzigi754 zpzigi754 zpzigi754 left review comments

@bokdeuk-jeong bokdeuk-jeong bokdeuk-jeong approved these changes

@nook1208 nook1208 Awaiting requested review from nook1208

@jinbpark jinbpark Awaiting requested review from jinbpark

@hihi-wang hihi-wang Awaiting requested review from hihi-wang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitboom @zpzigi754 @bokdeuk-jeong