Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acs: Pass 35/36 rec creation cases #185

Merged
merged 5 commits into from
Sep 22, 2023
Merged

acs: Pass 35/36 rec creation cases #185

merged 5 commits into from
Sep 22, 2023

Conversation

bitboom
Copy link
Collaborator

@bitboom bitboom commented Sep 21, 2023

This PR passes 35/36 in REC_CREATE by

  • Validate rmi arguments and rec params in REC_CREATE
  • Add RmiRecMpidr
  • Add rec_index to RD

Failed case

Failed case is related with B3.4.11 RmiRecCreateFlags.
The reserved fields of RmiRecCreateFlags must be zero.
But when i patched it like spec, it makes failures of other cases.
tf-rmm is also failed in this case.
I need more analysis of this case.

Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Copy link
Collaborator

@bokdeuk-jeong bokdeuk-jeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that islet passed all the test cases for rec creation!

Copy link
Collaborator

@nook1208 nook1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me :)

@bitboom bitboom merged commit 801730e into main Sep 22, 2023
6 checks passed
@bitboom bitboom deleted the rec-create branch September 22, 2023 01:33
@hihi-wang
Copy link
Collaborator

nice to increase pass rate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants