-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acs: Pass 35/36 rec creation cases #185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitboom
requested review from
nook1208,
zpzigi754,
bokdeuk-jeong,
jinbpark and
hihi-wang
September 21, 2023 04:20
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
bokdeuk-jeong
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice that islet passed all the test cases for rec creation!
nook1208
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me :)
nice to increase pass rate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes 35/36 in REC_CREATE by
rmi arguments
andrec params
in REC_CREATEFailed case
Failed case is related with
B3.4.11 RmiRecCreateFlags
.The reserved fields of
RmiRecCreateFlags
must be zero.But when i patched it like spec, it makes failures of other cases.
tf-rmm is also failed in this case.
I need more analysis of this case.