Upgrade ActiveSupport Version #4

Merged
merged 1 commit into from Aug 17, 2012

Conversation

Projects
None yet
2 participants
Contributor

jakeonrails commented Feb 11, 2012

  • Use bundler for gem deployment (rake build)
  • Use bundler for dependency management
  • Remove deprecated write_inheritable_attribute, and class_inheritable_attribute
  • Use Rspec 2
  • Remove Jeweler and associated files (Manifest.txt, PostInstall.txt, VERSION)
  • Remove script directory
  • Remove tasks directory
  • Remove rspec.opts in favor of user's .rspec configs.

@ismasan: Please let me know if anything needs to be changed. Also, I really haven't used the library much, so I literally just made the tests pass and submitted this - please play around with it a bit to make sure it works like you think it does. Specifically, the changes I made affect the way subclasses add to the maps class variable. I am not sure that the self.maps = self.maps.dup is the right way to go - so please keep that in mind.

@jakeonrails jakeonrails Upgrade ActiveSupport Version
 * Use bundler for gem deployment (rake build)
 * Use bundler for dependency management
 * Remove deprecated write_inheritable_attribute, and class_inheritable_attribute
 * Use Rspec 2
 * Remove Jeweler and associated files (Manifest.txt, PostInstall.txt, VERSION)
 * Remove script directory
 * Remove tasks directory
 * Remove rspec.opts in favor of user's .rspec configs.
37cca7e

@jakeonrails jakeonrails commented on the diff Feb 11, 2012

lib/hash_mapper.rb
end
end
def map(from, to, using=nil, &filter)
+ self.maps = self.maps.dup
@jakeonrails

jakeonrails Feb 11, 2012

Contributor

@ismasan This is the line I was talking about in the pull request.

ismasan merged commit 37cca7e into ismasan:master Aug 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment