Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw a helpful error if http argument is missing #1092

Merged
merged 1 commit into from Mar 17, 2020
Merged

fix: throw a helpful error if http argument is missing #1092

merged 1 commit into from Mar 17, 2020

Conversation

billiegoose
Copy link
Member

@billiegoose billiegoose commented Mar 17, 2020 •
edited

I'm fixing a bug or typo

fixes #1088

@karma-pr-reporter
Copy link

Test Results for 798fe1c:

Browser Pass Skip Fail Time Disconnect?
Chrome 79.0.3945 (Windows 10 0.0.0) 363 0 0 1m:34s false
Chrome Mobile 80.0.3987 (Android 0.0.0) 363 0 0 1m:44s false
Firefox 73.0.0 (Ubuntu 0.0.0) 363 0 0 0m:58s false
HeadlessChrome 0.0.0 (Linux 0.0.0) 363 0 0 0m:46s false
Mobile Safari 13.0.0 (iOS 13.0.0) 363 0 0 2m:1s false
Safari 13.0.3 (Mac OS X 10.15.1) 363 0 0 2m:35s false

Longest running tests

  • 9.82 secs - clone clone with noTags - Chrome
  • 8.726 secs - clone clone with noTags - Firefox
  • 8.472 secs - clone clone with noTags - Mobile Safari
  • 8.135 secs - clone clone with noTags - Safari
  • 6.521 secs - clone clone with noTags - HeadlessChrome
  • 5.888 secs - clone clone with noTags - Chrome Mobile
  • 5.316 secs - fetch shallow fetch relative (from Github) - Mobile Safari
  • 4.995 secs - fetch shallow fetch (from Github) - Mobile Safari
  • 4.946 secs - fetch shallow fetch (from Github) - Safari
  • 4.811 secs - fetch fetch --prune from git-http-mock-server - Safari
  • 4.551 secs - Hosting Providers GitLab push - Chrome Mobile

@billiegoose billiegoose merged commit 6564ea5 into master Mar 17, 2020
@billiegoose billiegoose deleted the fix/assert-http branch March 17, 2020 04:38
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
@billiegoose
fix: throw a helpful error if http argument is missing (isomorphic-…
4d9af98 
…git#1092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return a pretty error if http argument is missing
3 participants
@billiegoose @karma-pr-reporter @isomorphic-git-bot