Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): type of isDescendent depth argument should be number, not string #914

Merged
merged 3 commits into from Nov 14, 2019
Merged

fix(types): type of isDescendent depth argument should be number, not string #914

merged 3 commits into from Nov 14, 2019

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Oct 26, 2019

I'm fixing a bug or typo

  • if this is your first time contributing, run npm run add-contributor and follow the prompts to add yourself to the README
  • squash merge the PR with commit message "fix: [Description of fix]"

According to the jsDoc type annotations, the depth argument for the isDescendent function is an optional number:

* @param {number} [args.depth = -1] - Maximum depth to search before giving up. -1 means no maximum depth.

However, the Typescript typings file declares the argument as an optional string which causes tsc to fail:

depth?: string;

This pull request makes the jsDoc and Typescript typings consistent.

@karma-pr-reporter
Copy link

@karma-pr-reporter karma-pr-reporter commented Oct 26, 2019

Test Results for ee99c26:

Browser Pass Skip Fail Time Disconnect?
Chrome Mobile 69.0.3497 (Android 7.1.1) 312 1 0 3m:18s false
Edge 17.17134.0 (Windows 10 0.0.0) 312 1 0 4m:15s false
Firefox 69.0.0 (Ubuntu 0.0.0) 312 1 0 1m:55s false
HeadlessChrome 0.0.0 (Linux 0.0.0) 312 1 0 0m:51s false
Mobile Safari 11.0.0 (iOS 11.2.0) 311 2 0 3m:50s false
Safari 11.1.2 (Mac OS X 10.13.6) 312 1 0 3m:49s false

Longest running tests

  • 32.431 secs - fetch fetch --prune-tags from git-http-mock-server - Safari
  • 21.574 secs - fetch fetch (from Github) - Firefox
  • 20.371 secs - fetch fetch (from Github) - Edge
  • 18.016 secs - fetch shallow fetch (from Github) - Firefox
  • 17 secs - fetch shallow fetch relative (from Github) - Edge
  • 16.166 secs - GitPackIndex to .idx file from .pack - Edge
  • 14.719 secs - GitPackIndex from .pack - Edge
  • 12.785 secs - fetch fetch --prune-tags from git-http-mock-server - Firefox
  • 11.524 secs - fetch shallow fetch exclude (from Github) - Edge
  • 10.196 secs - merge merge 'delete-first-half' and 'delete-second-half' (dryRun, missing author) - Edge
  • 9.621 secs - fetch shallow fetch (from Github) - Edge

@wmhilton
Copy link
Member

@wmhilton wmhilton commented Nov 14, 2019

Oh! Nice! Ya nailed it. ❤️
18 days... man I should activate the beta of the new GitHub Notifications UX.

@wmhilton wmhilton changed the title fix: type of isDescendent depth argument should be number, not string fix(types): type of isDescendent depth argument should be number, not string Nov 14, 2019
@karma-pr-reporter
Copy link

@karma-pr-reporter karma-pr-reporter commented Nov 14, 2019

Test Results for 78ad45b:

Browser Pass Skip Fail Time Disconnect?
Chrome Mobile 69.0.3497 (Android 7.1.1) 316 1 0 3m:12s false
Edge 17.17134.0 (Windows 10 0.0.0) 316 1 0 4m:18s false
Firefox 70.0.0 (Ubuntu 0.0.0) 316 1 0 1m:55s false
HeadlessChrome 0.0.0 (Linux 0.0.0) 316 1 0 0m:51s false
Mobile Safari 11.0.0 (iOS 11.2.0) 248 2 0 4m:49s true
Safari 11.1.2 (Mac OS X 10.13.6) 315 1 1 3m:50s false

Erroring Tests

  • Safari 11.1.2 (Mac OS X 10.13.6):
    • commit pgp plugin signing - backwards compatiblity

Longest running tests

  • 25.01 secs - fetch fetch --prune-tags from git-http-mock-server - Safari
  • 21.967 secs - fetch fetch (from Github) - Edge
  • 18.811 secs - fetch shallow fetch (from Github) - Edge
  • 17.188 secs - fetch fetch --prune-tags from git-http-mock-server - Firefox
  • 16.586 secs - GitPackIndex from .pack - Edge
  • 16.089 secs - fetch shallow fetch relative (from Github) - Firefox
  • 15.267 secs - GitPackIndex to .idx file from .pack - Edge
  • 12.18 secs - fetch fetch (from Github) - Firefox
  • 11.785 secs - fetch shallow fetch (from Github) - Firefox
  • 10.263 secs - fetch shallow fetch since (from Github) - Edge
  • 9.375 secs - merge merge 'delete-first-half' and 'delete-second-half' (dryRun, missing author) - Edge

@karma-pr-reporter
Copy link

@karma-pr-reporter karma-pr-reporter commented Nov 14, 2019

Test Results for 78ad45b:

Browser Pass Skip Fail Time Disconnect?
Mobile Safari 11.0.0 (iOS 11.2.0) 315 2 0 3m:48s false
Safari 11.1.2 (Mac OS X 10.13.6) 316 1 0 3m:38s false

Longest running tests

  • 25.054 secs - fetch fetch --prune-tags from git-http-mock-server - Safari
  • 6.61 secs - fetch fetch (from Github) - Mobile Safari
  • 6.476 secs - walkBeta2 can populate type, mode, oid, and content - Safari
  • 5.743 secs - statusMatrix statusMatrix (pattern vs pattern + filepaths) - Safari
  • 5.493 secs - fetch shallow fetch (from Github) - Mobile Safari
  • 5.221 secs - statusMatrix statusMatrix (pattern vs pattern + filepaths) - Mobile Safari
  • 5.119 secs - fetch fetch --prune from git-http-mock-server - Mobile Safari
  • 4.205 secs - fetch shallow fetch (from Github) - Safari
  • 4.144 secs - merge merge 'remove-files' and 'add-files' - Safari
  • 4.059 secs - fetch shallow fetch relative (from Github) - Mobile Safari
  • 4.017 secs - status status - Safari

@wmhilton wmhilton merged commit 3f84b78 into isomorphic-git:master Nov 14, 2019
1 check passed
@isomorphic-git-bot
Copy link
Member

@isomorphic-git-bot isomorphic-git-bot commented Nov 14, 2019

🎉 This PR is included in version 0.70.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@c-w c-w deleted the fix/isdescendent-depth-type branch Nov 14, 2019
@isomorphic-git-bot
Copy link
Member

@isomorphic-git-bot isomorphic-git-bot commented Jan 24, 2020

🎉 This PR is included in version 1.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants