Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Reading bee backstory #69

Merged
merged 3 commits into from
Sep 28, 2023
Merged

add Reading bee backstory #69

merged 3 commits into from
Sep 28, 2023

Conversation

xmulligan
Copy link
Member

No description provided.

@xmulligan xmulligan requested a review from qmonnet September 8, 2023 14:36
@xmulligan xmulligan linked an issue Sep 8, 2023 that may be closed by this pull request
Copy link
Contributor

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want real people names in the eBeeDex? There's Liz's name and Roland's (on the picture). Makes it harder to reuse the picture in my opinion, and I'd avoid adding people altogether, but maybe that's just me.

Apart for the typo, the story looks fine otherwise.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Quentin Monnet <quentin@isovalent.com>
@xmulligan
Copy link
Member Author

We have Daniel's and Alexei's names in stories above. I kind of like it because it shows that there are real people behind the code too.

@qmonnet
Copy link
Contributor

qmonnet commented Sep 11, 2023

OK. Even in the pictures themselves though?

Looks good to merge, if you want to keep the names.

@xmulligan
Copy link
Member Author

Yes, I like it with the names because I think it gives some personality and it's kind of like a snapshot in time

@xmulligan xmulligan requested a review from qmonnet September 28, 2023 02:10
@qmonnet qmonnet merged commit 76680a5 into main Sep 28, 2023
@qmonnet qmonnet deleted the reading-bee branch September 28, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eBee Spotted: Reading eBee
2 participants