Repository navigation
Conversation
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
Collaborator
|
Several notes before you finalize the PR:
|
karthik-senthil
force-pushed
the
ZizmoreCI
branch
from
October 10, 2025 20:39
0219cc7 to
8448bb9
Compare
aneshlya
approved these changes
Oct 10, 2025
aneshlya
left a comment
aneshlya
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! Thanks! I'd like to merge when the workloads pass (looks like there is some temporary problem on Github runners)
6 tasks
zizmor is intended to replace actionlint as it has better support. Github issue: #3585
Includes: - auto-fixes by zizmor - manual fixes missed by auto-fix framework - pinning archlinux image version
zizmor is expected to replace actionlint.
offsake
reviewed
Nov 7, 2025
| push: | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/*' |
There was a problem hiding this comment.
Can/Should it be '.github/workflows/**' ?
Collaborator
There was a problem hiding this comment.
It can be '.github/workflows/**' for future proof. But for now all our workflows are in .github/workflows/ and we don't plan to introduce any hierarchy there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zizmor is intended to replace actionlint as it has better support.
Github issue: #3585
Related Issue
Checklist
clang-format(e.g.,clang-format -i src/ispc.cpp)