share: isso.conf: Use dashed-case for misaka 2.0 #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Misaka expects extensions and flags in `dashed-case` instead of the legacy `snake_case` as of version 2.0. See https://github.com/FSX/misaka/blob/v2.1.1/misaka/utils.py#L15-L37 Also align "options" values with the defaults in `utils/html.py`.
jelmer
reviewed
Feb 7, 2021
| options = strikethrough, autolink, fenced_code, no_intra_emphasis | ||
| # Misaka-specific Markdown extensions, all extensions can be used here, | ||
| # separated by comma, either by their name or by EXT_<extension>. | ||
| # Careful: Misaka 1.0 used "snake_case", but 2.0 needs "dashed-case"! |
There was a problem hiding this comment.
We've been on misaka 2.0 since 1.5, do we really need to mention misaka 1.0?
There was a problem hiding this comment.
I was directing that comment towards people upgrading from older versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misaka expects extensions and flags in
dashed-caseinstead of the legacysnake_caseas of version 2.0.See https://github.com/FSX/misaka/blob/v2.1.1/misaka/utils.py#L15-L37
Also align "options" values with the defaults in
utils/html.py.