Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I get an exception when trying to instrument a jar file:
It seems that the jar file can not be properly extracted. Could you maybe add the same behavior here, so that if it can not be extracted, instrumentation is skipped and the jar used as-is? That would be super cool.
Hm, while looking at this bug I'm not really sure if the recursion in the extractJar method is correctly implemented. Because if there is a jar in a jar, I think you can not simply read the jar inside by specifying a "path", like here:
But I'm unsure.
Hmm I'm not sure if I actually tested with nested JARs. You are right about the extractJar method.
As a workaround, for now, you can comment out lines 97 and 99 of JarFileIO.java. Your output will then have the original, uninstrumented JAR.
Please feel free to send in a pull request to fix this.