Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to skip rows with full coverage #170

Merged
merged 1 commit into from Jun 6, 2018

Conversation

chrismohr
Copy link
Contributor

@chrismohr chrismohr commented May 20, 2018

#169

Looking forward to feedback on this.
Let me know if this is a change you'd be interested in taking, and I can work on adding test coverage.

@chrismohr chrismohr force-pushed the hide_full_coverage_report branch from acbb15f to e6e7bf4 Compare May 20, 2018
@coveralls
Copy link

coveralls commented May 20, 2018

Coverage Status

Coverage decreased (-0.2%) to 87.809% when pulling e6e7bf4 on chrismohr:hide_full_coverage_report into ac824a4 on istanbuljs:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 20, 2018

Coverage Status

Coverage decreased (-0.2%) to 87.809% when pulling e6e7bf4 on chrismohr:hide_full_coverage_report into ac824a4 on istanbuljs:master.

@bcoe
Copy link
Member

bcoe commented May 31, 2018

Hey @chrismohr 👋 sorry for the slow turnaround on issues these days. will try to get you feedback as soon as possible.

feel free to join the community slack we run if you want to help kick things along:

http://devtoolscommunity.herokuapp.com/

bcoe
bcoe approved these changes Jun 6, 2018
Copy link
Member

@bcoe bcoe left a comment

@chrismohr I like this feature idea quite a bit, thank you for the contribution.

@bcoe bcoe merged commit bbcdc07 into istanbuljs:master Jun 6, 2018
2 of 3 checks passed
@chrismohr
Copy link
Contributor Author

chrismohr commented Jun 6, 2018

Awesome. Thank you @bcoe!

@chrismohr chrismohr deleted the hide_full_coverage_report branch Jun 6, 2018
@bcoe
Copy link
Member

bcoe commented Jun 8, 2018

@chrismohr your work is now available in nyc@next, please let me know if this branch works properly for you.

Yukaii pushed a commit to hackmdio/istanbuljs that referenced this issue Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants