Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not crash when nyc is run inside itself. #1068

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@coreyfarrell
Copy link
Member

commented Apr 16, 2019

Fixes #1067

@coreyfarrell coreyfarrell requested a review from isaacs Apr 16, 2019

@coveralls

This comment has been minimized.

Copy link

commented Apr 16, 2019

Coverage Status

Coverage remained the same at 96.65% when pulling c91c10a on coreyfarrell:issue-1067 into e21721a on istanbuljs:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Apr 16, 2019

Coverage Status

Coverage remained the same at 96.65% when pulling c91c10a on coreyfarrell:issue-1067 into e21721a on istanbuljs:master.

@isaacs

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

This looks good to me. We should do a deeper investigation/design some day to work out how nested NYC's should behave, but not crashing is better than crashing in this case.

@coreyfarrell coreyfarrell merged commit c4fcf5e into istanbuljs:master Apr 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.65%
Details

@coreyfarrell coreyfarrell deleted the coreyfarrell:issue-1067 branch Apr 16, 2019

coreyfarrell added a commit to coreyfarrell/istanbul-lib-processinfo that referenced this pull request Apr 16, 2019
coreyfarrell added a commit to coreyfarrell/istanbul-lib-processinfo that referenced this pull request Apr 16, 2019
coreyfarrell added a commit to istanbuljs/istanbul-lib-processinfo that referenced this pull request Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.