Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack badge image insecure content warning #1105

Merged
merged 1 commit into from May 8, 2019

Conversation

@calvinf
Copy link
Contributor

commented May 8, 2019

Image is no longer insecure when viewing REAMDE off of github (which does not serve the original image URLs). Previously, the insecure content warning would show on npm when viewing the nyc package.

Image is no longer insecure when viewing REAMDE off of github (which does not serve the original image URLs).
@JaKXz
JaKXz approved these changes May 8, 2019
Copy link
Member

left a comment

Thanks!

@JaKXz JaKXz merged commit 0cc7309 into istanbuljs:master May 8, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@coveralls

This comment has been minimized.

Copy link

commented May 8, 2019

Coverage Status

Coverage remained the same at 96.87% when pulling 93ba05f on calvinf:patch-1 into 3cdfb8e on istanbuljs:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented May 8, 2019

Coverage Status

Coverage remained the same at 96.87% when pulling 93ba05f on calvinf:patch-1 into 3cdfb8e on istanbuljs:master.

@calvinf calvinf deleted the calvinf:patch-1 branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.