Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Point to updated location of default exclude list #1107

Merged
merged 1 commit into from May 9, 2019

Conversation

@coreyfarrell
Copy link
Member

commented May 9, 2019

No description provided.

@coreyfarrell coreyfarrell merged commit b3dfae8 into istanbuljs:master May 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on docs-default-exclude at 96.87%
Details

@coreyfarrell coreyfarrell deleted the coreyfarrell:docs-default-exclude branch May 9, 2019

@@ -100,7 +100,7 @@ This table is a quick TLDR for the rest of this readme and there are more advanc
| `check-coverage` | Check whether coverage is within thresholds, fail if not | `Boolean` | `false` |
| `extension` | List of extensions that nyc should attempt to handle in addition to `.js` | `Array<String>` | `['.js']` |
| `include` | See [selecting files for coverage] for more info | `Array<String>` | `['**']`|
| `exclude` | See [selecting files for coverage] for more info | `Array<String>` | [list](https://github.com/istanbuljs/istanbuljs/blob/master/packages/test-exclude/index.js#L176-L184) |
| `exclude` | See [selecting files for coverage] for more info | `Array<String>` | [list](https://github.com/istanbuljs/istanbuljs/blob/master/packages/test-exclude/default-exclude.js) |

This comment has been minimized.

Copy link
@JaKXz

JaKXz May 9, 2019

Member

This list is also mentioned (and already outdated) in the selecting files for coverage section. We should fix that, ideally with a github embed in the readme in that section rather than the static list...

This comment has been minimized.

Copy link
@coreyfarrell

coreyfarrell May 9, 2019

Author Member

I can link the content but I'm not sure how to embed content in a README? I think that might be a special feature just for issue/PR comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.