Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 1:many source-maps #21

Closed
bcoe opened this issue Apr 29, 2019 · 5 comments
Closed

add support for 1:many source-maps #21

bcoe opened this issue Apr 29, 2019 · 5 comments

Comments

@bcoe
Copy link
Member

bcoe commented Apr 29, 2019

we should add support for source-maps that map from one transpiled source to many original sources, this is an extension to the work done in #19.

@scythargon
Copy link

scythargon commented Jul 20, 2019

Hi! Is this related? facebook/jest#8596
I mean, seeing the progress on that Jest PR - will it help with this one?

@bcoe
Copy link
Member Author

bcoe commented Jul 29, 2019

@scythargon I don't think that the 1:many issue is specifically blocking Jest; this relates to the specific use case of combination, so if you have foo.js, bar.js, and then deploy a source file that's bar.js + foo.js.

@felixfbecker
Copy link

felixfbecker commented Aug 17, 2019

This is needed if any bundler like webpack is used

@lukeapage
Copy link

lukeapage commented Feb 12, 2020

I started trying to hack this in to get to poc stage:
lukeapage@c169da3

but I'm pretty close to giving up - the above appears to work but I don't understand why lines start with a count of 1 - I'll try to continue bashing my head against it. also not sure if the issues I am having are down to the fact I'm using output from playwright, piped through pupeteer-to-istanbul.

@lukeapage
Copy link

lukeapage commented Feb 13, 2020

Would appreciate feedback and testing on #91
It turned out pupeteer/playwright output is screwed, but getting the raw v8 output and piping it in worked well.

@bcoe bcoe closed this as completed in d1f435c Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants