Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix 404 link in content/zh/get-involved/_index.md #10822

Merged
merged 3 commits into from Jan 24, 2022
Merged

docs: fix 404 link in content/zh/get-involved/_index.md #10822

merged 3 commits into from Jan 24, 2022

Conversation

foolwc
Copy link
Contributor

@foolwc foolwc commented Jan 24, 2022

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@foolwc foolwc requested a review from a team as a code owner January 24, 2022 06:55
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 24, 2022
@istio-testing
Copy link
Contributor

Hi @foolwc. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Xunzhuo
Copy link
Member

Xunzhuo commented Jan 24, 2022

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 24, 2022
Xunzhuo
Xunzhuo reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@Xunzhuo Xunzhuo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @rootsongjc, do we need to update ServiceMesher to Cloud Native Community in China?

@Xunzhuo Xunzhuo added the do-not-merge Block automatic merging of a PR. label Jan 24, 2022
@rootsongjc
Copy link
Member

rootsongjc commented Jan 24, 2022 •
edited

cc @rootsongjc, do we need to update ServiceMesher to Cloud Native Community in China?

Yes, I think so. Please go ahead to update that link and text. @Xunzhuo

@Xunzhuo
Copy link
Member

Xunzhuo commented Jan 24, 2022

/retest

@Xunzhuo Xunzhuo added cherrypick/release-1.13 Set this label on a PR to auto-merge it to the release-1.13 branch translation/chinese Translation item and removed do-not-merge Block automatic merging of a PR. labels Jan 24, 2022
rootsongjc
rootsongjc approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing istio-testing merged commit 810068a into istio:master Jan 24, 2022
@foolwc foolwc deleted the fix-link branch January 24, 2022 09:22
@Xunzhuo
Copy link
Member

Xunzhuo commented Jan 24, 2022

/cherry-pick release-1.12

@istio-testing
Copy link
Contributor

@Xunzhuo: new pull request created: #10824

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootsongjc rootsongjc rootsongjc approved these changes

@Xunzhuo Xunzhuo Xunzhuo approved these changes

Assignees
No one assigned
Labels
cherrypick/release-1.13 Set this label on a PR to auto-merge it to the release-1.13 branch ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@foolwc @istio-testing @Xunzhuo @rootsongjc