-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mistranslate of /zh/docs/setup/kubernetes/helm-install #2270
fix mistranslate of /zh/docs/setup/kubernetes/helm-install #2270
Conversation
Hi @trainyao. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CI failed with the following outputs.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rootsongjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix extra brace (#2263) (cherry picked from commit 586c740) * Translate help/ops/component-debugging into Chinese (#2255) Rebase component-logging (cherry picked from commit 8d80491) * Translate help/faq/traffic-management into Chinese;Fix format (#2267) (cherry picked from commit 034548e) * Translate help/faq/telemery into Chinese (#2269) * Translate help/faq/telemery into Chinese;Fix space * Fix ci failed (cherry picked from commit ada8c96) * translate /help/ops/missing-metrics (#2265) * translate /help/ops/missing-metrics * change title (cherry picked from commit 60296ae) * Extend the secure ingress task with multiple ingress certificates/hosts (#2238) * generate certificates in httpbin.example.com directory * add initial section for ingress for multiple hosts * add a cleanup step for the directories related to certificates * fix formatting * add subsection: Redeploy istio-ingressgateway with the new certificates * rename httpbin-gateway into mygateway * add redeployment of Gateway for two hosts * add -o /dev/null -s -w "%{http_code}\n" to the bookinfo's curl * fix italics in sending a request to bookinfo * add verify that httpbin.example.com is accessible as previously * add -v to curl to bookinfo, show certificates printed * remove -n istio-system from virtualservice bookinfo * add Host header to curl requests * put empty lines around the code blocks * fix spell checker errors (cherry picked from commit d5cb694) * add 'location: MESH_EXTERNAL' to the service entries (#2226) it is currently not required, however for the sake of proper configuration it should be added (cherry picked from commit b2bb9c5) * add DestinationRule to example (#2261) (cherry picked from commit beeb9c3) * fix sample RbacConfig in concept page. (#2253) (cherry picked from commit 053efb7) * Highlight "Istio multicluster" in example document. (#2196) (cherry picked from commit 670fb9e) * fix mistranslate of /zh/docs/setup/kubernetes/helm-install (#2270) * fix mistranslate of /zh/docs/setup/kubernetes/helm-install * fix related link of changed title (cherry picked from commit 54327f7) * translation:/content/help/faq/mixer/index.md (#2250) * traslation:/content/docs/concepts/index.md * traslation:/content/docs/reference/config/authorization/_index.md * traslation:/content/docs/reference/config/authorization/_index.md * traslation:/content/docs/reference/config/authorization/_index.md * trigger * trigger * translation:/content/help/faq/mixer/index.md * translation:/content/help/faq/mixer/index.md 格式问题 (cherry picked from commit e497125) * Translate expression-language into chinese (#2134) * Translate expression-language into chinese * add spaces between chinese and english words, for expression-language page (#2134) * delete repeat character,add spaces (#2134) * add period to title end (#2134) * remove alias * remove spelling (cherry picked from commit 9dd2adb) * Translate into Chinese: help/faq/security/https-overlay.md (#2272) * Translate into Chinese: help/faq/security/https-overlay.md * Update https-overlay.md * Update https-overlay.md * Update https-overlay.md * Update https-overlay.md * Trigger CI * Trigger CI * Update https-overlay.md (cherry picked from commit 32529b0) * Translate into Chinese: help/faq/security/check-policy.md (#2276) * Translate into Chinese: help/faq/security/check-policy.md * Update check-policy.md * Update CI (cherry picked from commit 5064a5f) * adding schedule to istio twich live stream page (#2274) * Adding twitch stream schedule to content * --amend (cherry picked from commit 86c0dd3) * Spell Lisa's name correctly (#2279) (cherry picked from commit b73b6a8) * Switch to Hugo 0.47 (#2288) - Fixes the bug where not all of our files would get the right lastmod time extracted from GitHub. - Fixes most of the cases of bad HTML output around the use of {{<text>}}. There's still a single bad case which I'll report to the Hugo folks. - Use Hugo's new --minify option to minify HTML instead of having to use the separate and slow html-minifier program. - Fix some bad HTML on the landing page. (cherry picked from commit be7c374) * suggest a more recent gke minor version (#2283) ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=Master version "1.10.5-gke.0" is unsupported. (cherry picked from commit 4a49a2d) * translate update setup requirement (#2282) (cherry picked from commit 083de5b) * translate: update taks/traffic-management/egress (#2280) (cherry picked from commit c10b355) * Delete special chars and turn on HTML checking (#2292) * Delete special chars and turn on HTML checking - Refer to #2289 and issue #2290 - Delete the special chars in Chinese content - Turn on HTML checking to highlight problems * delete the redundant period (cherry picked from commit 91d2481) * remove extra space before dot (#2305) (cherry picked from commit f8f20af) * Bunch of site fixes & improvements. (#2306) - Correct the use of OpenGraph annotations. I used the wrong attribute name, so the annotations were never recognized. - Added support for Twitter cards to our site, improving the experience of referencing the site from Twitter posts. - Added support for the twitter: front matter field for use in blog posts. Specifying this front-matter entry will show the author's twitter address on the blog post, and will add a Twitter card entry to the page noting the author's address. - Renamed the page_icon front matter field to just icon to be consistent with other entries. - Made it so the subtitle front matter field can be used anywhere, not just on blog posts. - Added a lint check to ensure subtitles don't end with a period. - We now insert an "author" metadata entry whenever the attribution: front matter field is used. (cherry picked from commit 5e29d61)
* Fix extra brace (istio#2263) (cherry picked from commit 586c740) * Translate help/ops/component-debugging into Chinese (istio#2255) Rebase component-logging (cherry picked from commit 8d80491) * Translate help/faq/traffic-management into Chinese;Fix format (istio#2267) (cherry picked from commit 034548e) * Translate help/faq/telemery into Chinese (istio#2269) * Translate help/faq/telemery into Chinese;Fix space * Fix ci failed (cherry picked from commit ada8c96) * translate /help/ops/missing-metrics (istio#2265) * translate /help/ops/missing-metrics * change title (cherry picked from commit 60296ae) * Extend the secure ingress task with multiple ingress certificates/hosts (istio#2238) * generate certificates in httpbin.example.com directory * add initial section for ingress for multiple hosts * add a cleanup step for the directories related to certificates * fix formatting * add subsection: Redeploy istio-ingressgateway with the new certificates * rename httpbin-gateway into mygateway * add redeployment of Gateway for two hosts * add -o /dev/null -s -w "%{http_code}\n" to the bookinfo's curl * fix italics in sending a request to bookinfo * add verify that httpbin.example.com is accessible as previously * add -v to curl to bookinfo, show certificates printed * remove -n istio-system from virtualservice bookinfo * add Host header to curl requests * put empty lines around the code blocks * fix spell checker errors (cherry picked from commit d5cb694) * add 'location: MESH_EXTERNAL' to the service entries (istio#2226) it is currently not required, however for the sake of proper configuration it should be added (cherry picked from commit b2bb9c5) * add DestinationRule to example (istio#2261) (cherry picked from commit beeb9c3) * fix sample RbacConfig in concept page. (istio#2253) (cherry picked from commit 053efb7) * Highlight "Istio multicluster" in example document. (istio#2196) (cherry picked from commit 670fb9e) * fix mistranslate of /zh/docs/setup/kubernetes/helm-install (istio#2270) * fix mistranslate of /zh/docs/setup/kubernetes/helm-install * fix related link of changed title (cherry picked from commit 54327f7) * translation:/content/help/faq/mixer/index.md (istio#2250) * traslation:/content/docs/concepts/index.md * traslation:/content/docs/reference/config/authorization/_index.md * traslation:/content/docs/reference/config/authorization/_index.md * traslation:/content/docs/reference/config/authorization/_index.md * trigger * trigger * translation:/content/help/faq/mixer/index.md * translation:/content/help/faq/mixer/index.md 格式问题 (cherry picked from commit e497125) * Translate expression-language into chinese (istio#2134) * Translate expression-language into chinese * add spaces between chinese and english words, for expression-language page (istio#2134) * delete repeat character,add spaces (istio#2134) * add period to title end (istio#2134) * remove alias * remove spelling (cherry picked from commit 9dd2adb) * Translate into Chinese: help/faq/security/https-overlay.md (istio#2272) * Translate into Chinese: help/faq/security/https-overlay.md * Update https-overlay.md * Update https-overlay.md * Update https-overlay.md * Update https-overlay.md * Trigger CI * Trigger CI * Update https-overlay.md (cherry picked from commit 32529b0) * Translate into Chinese: help/faq/security/check-policy.md (istio#2276) * Translate into Chinese: help/faq/security/check-policy.md * Update check-policy.md * Update CI (cherry picked from commit 5064a5f) * adding schedule to istio twich live stream page (istio#2274) * Adding twitch stream schedule to content * --amend (cherry picked from commit 86c0dd3) * Spell Lisa's name correctly (istio#2279) (cherry picked from commit b73b6a8) * Switch to Hugo 0.47 (istio#2288) - Fixes the bug where not all of our files would get the right lastmod time extracted from GitHub. - Fixes most of the cases of bad HTML output around the use of {{<text>}}. There's still a single bad case which I'll report to the Hugo folks. - Use Hugo's new --minify option to minify HTML instead of having to use the separate and slow html-minifier program. - Fix some bad HTML on the landing page. (cherry picked from commit be7c374) * suggest a more recent gke minor version (istio#2283) ERROR: (gcloud.container.clusters.create) ResponseError: code=400, message=Master version "1.10.5-gke.0" is unsupported. (cherry picked from commit 4a49a2d) * translate update setup requirement (istio#2282) (cherry picked from commit 083de5b) * translate: update taks/traffic-management/egress (istio#2280) (cherry picked from commit c10b355) * Delete special chars and turn on HTML checking (istio#2292) * Delete special chars and turn on HTML checking - Refer to istio#2289 and issue istio#2290 - Delete the special chars in Chinese content - Turn on HTML checking to highlight problems * delete the redundant period (cherry picked from commit 91d2481) * remove extra space before dot (istio#2305) (cherry picked from commit f8f20af) * Bunch of site fixes & improvements. (istio#2306) - Correct the use of OpenGraph annotations. I used the wrong attribute name, so the annotations were never recognized. - Added support for Twitter cards to our site, improving the experience of referencing the site from Twitter posts. - Added support for the twitter: front matter field for use in blog posts. Specifying this front-matter entry will show the author's twitter address on the blog post, and will add a Twitter card entry to the page noting the author's address. - Renamed the page_icon front matter field to just icon to be consistent with other entries. - Made it so the subtitle front matter field can be used anywhere, not just on blog posts. - Added a lint check to ensure subtitles don't end with a period. - We now insert an "author" metadata entry whenever the attribution: front matter field is used. (cherry picked from commit 5e29d61)
No description provided.