Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs regarding when to use flexible mTLS #3616

Merged
merged 2 commits into from Mar 12, 2019

Conversation

Projects
None yet
4 participants
@nhooyr
Copy link
Contributor

nhooyr commented Mar 10, 2019

mTLS is now supported with stateful sets and headless services.

See istio/istio#1277

@googlebot googlebot added the cla: yes label Mar 10, 2019

@istio-testing istio-testing requested review from frankbu and rcaballeromx Mar 10, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Mar 10, 2019

Hi @nhooyr. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Mar 12, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Mar 12, 2019

Update docs regarding when to use flexible mTLS
mTLS is now supported with stateful sets and headless services.

See istio/istio#1277

@nhooyr nhooyr force-pushed the nhooyr:mtls branch from 09426d4 to 9cb01d6 Mar 12, 2019

@nhooyr nhooyr force-pushed the nhooyr:mtls branch from 9cb01d6 to 7b2b1a8 Mar 12, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Mar 12, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@frankbu
Copy link
Contributor

frankbu left a comment

/lgtm
/approve

@istio-testing istio-testing added the lgtm label Mar 12, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Mar 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, nhooyr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit d1381dc into istio:master Mar 12, 2019

3 of 4 checks passed

tide Not mergeable. Needs approved, lgtm labels.
Details
ci/circleci Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
deploy/netlify Deploy preview ready!
Details

@nhooyr nhooyr deleted the nhooyr:mtls branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.