Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh: help/ops/setup/app-health-check #3772

Closed
wants to merge 10 commits into from

Conversation

5 participants
@loverto
Copy link
Member

commented Mar 19, 2019

move and update

Signed-off-by: ylf 1045438139@qq.com

zh: help/ops/setup/app-health-check
move and update

Signed-off-by: ylf <1045438139@qq.com>

geeknoid and others added some commits Mar 19, 2019

zh: /help/faq/distributed-tracing/mixer-role.md (#3776)
* zh: /help/faq/distributed-tracing/mixer-role.md

* typo
@fleeto

This comment has been minimized.

Copy link
Member

commented Mar 25, 2019

please switch to release-1.1

@loverto loverto changed the base branch from master to release-1.1 Mar 28, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Mar 28, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: loverto
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rootsongjc

If they are not already assigned, you can assign the PR to them by writing /assign @rootsongjc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot

This comment has been minimized.

Copy link

commented Mar 28, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Mar 28, 2019

@loverto loverto closed this Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.