Create cluster-admin rolebinding #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins job istio.github.io/presubmit passed |
|
Jenkins job istio.github.io/presubmit passed |
rshriram
reviewed
Sep 29, 2017
| credentials for kubectl: | ||
| 2. Grant cluster admin permissions to the current user - admin permissions are required to create the necessary RBAC rules for Istio: | ||
| ```bash | ||
| kubectl create clusterrolebinding cluster-admin-binding --clusterrole=cluster-admin --user=$(gcloud config get-value core/account) |
There was a problem hiding this comment.
this seems overly indented.. shouldn't it start from the same column as backtick?
There was a problem hiding this comment.
yup, the indentation is wrong everywhere.
There was a problem hiding this comment.
looks fine everywhere except here as far as I can see
rshriram
approved these changes
Sep 29, 2017
ldemailly
approved these changes
Sep 29, 2017
| credentials for kubectl: | ||
| 2. Grant cluster admin permissions to the current user - admin permissions are required to create the necessary RBAC rules for Istio: | ||
| ```bash | ||
| kubectl create clusterrolebinding cluster-admin-binding --clusterrole=cluster-admin --user=$(gcloud config get-value core/account) |
There was a problem hiding this comment.
looks fine everywhere except here as far as I can see
|
Jenkins job istio.github.io/presubmit passed |
|
Jenkins job istio.github.io/presubmit passed |
|
Jenkins job istio.github.io/presubmit passed |
|
merged so I can close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions specific to GKE.