New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: enlarge search icon for better visibility #8459
Conversation
Signed-off-by: Kush Trivedi <kushthedude@gmail.com>
Hi @kushthedude. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what the first file changed does. I am APPROVING this PR - with the assumption that another reviewer will ensure the changes to the layout file are correct.
Really nice job - especially for a first PR!!
Rendering: https://deploy-preview-8459--preliminary-istio.netlify.app/
For a followup independent PR, would you be willing to enhance the size of the Options and Settings
gear icon to match the size of this search icon?
And for a final PR - could you enhance the size of the X box next to the search icon. It is really hard to find...
It may be that not all of these enhancements are accepted, which is why I requested per PR enhancements (so they could be individually reviewed).
I find these types of changes super beneficial for those with vision difficulty (such as myself). These relatively small changes have an awesome impact on accessibility.
/ok-to-test |
Thanks, @sdake!
The first file change is needed to add an extra attribute to the class with the icon name so that when the class name would be
Sure I will make the follow-up PRs for the issues you mentioned 😄 |
@kushthedude Thanks for the enhancement, but I'm not sure if we should be tweaking these kinds of things outside of a more coordinated overall improvement to the site usability. There is work underway to improve the UX and layout, but maybe this is OK as a temporary improvement? @craigbox, how does this fit with things you are planning? |
We'll be doing a complete visual overhaul of the site in the next 3 months, but it will probably not land for a while, and so enhancements like these to the existing site are super useful. Thanks, Kush! |
Signed-off-by: Kush Trivedi kushthedude@gmail.com
[ ] Configuration Infrastructure
[X] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure