Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Gateways can't have dots in their name #13211
Describe the bug
Steps to reproduce the bug
Create a gateway manifest containing a dot in the name like :
You can check the listener created for the
The resulting route is just the default
When you change the
This is even more obvious with
aren't kubernetes names supposed to be DNS1123 labels (no dots)? if gateway name has dots, then it is trouble. In Istio 1.0.x, we asked people to refer to cross namesapce gateawys as gatewayname.namesapce.svc.cluster.local.. But starting in 1.1, we are asking people to refer to gateways as namespace/name [consistent with the way we are referring to services in the Sidecar CRD object].
As a backward compatibility measure, we continue to parse the old format as well, but internally we convert it into namespace/name format. So I guess what happened here is that our simple minded parsing ( split(gatewayName, '.')/split(gatewayName, '.')) doesn't work.
So yes, we should add validation to ensure that the Gateway Object's name does not contain a dot.
As far as I remember, I also tried to reference the gateway (in a VirtualService) as
I switched the GW name to not use dots at all, and created my
Still, this situation is under-documented and not enforced as needed.