Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The destination_service_name label for TCP metrics is not set for BlackHole & Passthrough cluster #17271

Closed
nrjpoddar opened this issue Sep 20, 2019 · 2 comments

Comments

@nrjpoddar
Copy link
Member

@nrjpoddar nrjpoddar commented Sep 20, 2019

Bug description

The destination_service_name label for TCP metrics is set to "unknown" when either of these clusters are used.

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Expected behavior
The destination_service_name label for TCP metrics should be set to "BlackHoleCluster" or "PassthroughCluster" in these cases.

Steps to reproduce the bug
Run TCP traffic through your cluster and hit BlackHole or Passthrough cluster. Observe the destination_service_name label in istio_tcp_* metrics.

Version (include the output of istioctl version --remote and kubectl version)
1.3

@nrjpoddar nrjpoddar self-assigned this Sep 20, 2019
@nrjpoddar

This comment has been minimized.

Copy link
Member Author

@nrjpoddar nrjpoddar commented Sep 20, 2019

@nrjpoddar

This comment has been minimized.

Copy link
Member Author

@nrjpoddar nrjpoddar commented Sep 20, 2019

The change I had added got reverted incorrectly in this PR: #13631

https://github.com/istio/istio/pull/13631/files#diff-d92228a902ebeed8f59f07f6408ae717L575

@howardjohn you might be interested.

@douglas-reid douglas-reid added this to the 1.4 milestone Sep 20, 2019
nrjpoddar added a commit to nrjpoddar/istio that referenced this issue Nov 2, 2019
istio-testing added a commit to istio-testing/istio that referenced this issue Nov 4, 2019
nrjpoddar added a commit to nrjpoddar/istio that referenced this issue Nov 4, 2019
* Add fallthrough listener filer chain for BlackHoleCluster

* Fix telemetry reported

Fixes: istio#17271 istio#17759

* Tests for IsAllowAnyOutbound

* Use t.Run

* Added mixer plugin tests

* Added listener tests
istio-testing added a commit that referenced this issue Nov 5, 2019
…er (#18619)

* Add fallthrough listener filer chain for BlackHoleCluster

* Fix telemetry reported

Fixes: #17271 #17759

* Tests for IsAllowAnyOutbound

* Use t.Run

* Added mixer plugin tests

* Added listener tests
nrjpoddar added a commit to nrjpoddar/istio that referenced this issue Nov 6, 2019
* Add fallthrough listener filer chain for BlackHoleCluster

* Fix telemetry reported

Fixes: istio#17271 istio#17759

* Tests for IsAllowAnyOutbound

* Use t.Run

* Added mixer plugin tests

* Added listener tests
istio-testing added a commit that referenced this issue Nov 6, 2019
…18620)

* Add fallthrough listener filer chain for BlackHoleCluster (#18541)

* Add fallthrough listener filer chain for BlackHoleCluster

* Fix telemetry reported

Fixes: #17271 #17759

* Tests for IsAllowAnyOutbound

* Use t.Run

* Added mixer plugin tests

* Added listener tests

* Fix unit tests

* Fix unit tests

* Fix lint
sdake added a commit to sdake/istio that referenced this issue Dec 1, 2019
* Add fallthrough listener filer chain for BlackHoleCluster

* Fix telemetry reported

Fixes: istio#17271 istio#17759

* Tests for IsAllowAnyOutbound

* Use t.Run

* Added mixer plugin tests

* Added listener tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.