Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator logs error messages to stdout instead of stderr #17743

Closed
howardjohn opened this issue Oct 10, 2019 · 8 comments · Fixed by istio/operator#535, istio/operator#555 or istio/operator#689
Closed

Comments

@howardjohn
Copy link
Member

@howardjohn howardjohn commented Oct 10, 2019

This makes doing things like istioctl manifest generate > file.yaml unusable. Example error:

could not unmarshal the overlay file: unknown field "imagePullPolicy" in v1alpha2.IstioControlPlaneSpec

Original YAML:
apiVersion: install.istio.io/v1alpha2
kind: IstioControlPlane
spec:
  hub: foo123
  tag: foo123
  imagePullPolicy: foo123
@elfinhe

This comment has been minimized.

Copy link
Member

@elfinhe elfinhe commented Oct 11, 2019

https://github.com/istio/operator/blob/master/cmd/mesh/shared.go#L83
maybe we can change this line, I will create a PR.

@ostromart

This comment has been minimized.

Copy link
Contributor

@ostromart ostromart commented Oct 13, 2019

We need a bit more work on this. logtostderr is not the same as having errors show up in stderr.

@ostromart ostromart added this to the 1.4 milestone Oct 18, 2019
@howardjohn

This comment has been minimized.

Copy link
Member Author

@howardjohn howardjohn commented Oct 23, 2019

This breaks ik manifest migrate install/kubernetes/helm/istio/test-values/values-e2e.yaml > file

@ostromart ostromart assigned richardwxn and unassigned richardwxn Oct 24, 2019
@ostromart

This comment has been minimized.

Copy link
Contributor

@ostromart ostromart commented Oct 24, 2019

Actually, I created a new issue for this, seems it's not really related to error logging:
#18289

@ostromart

This comment has been minimized.

Copy link
Contributor

@ostromart ostromart commented Nov 5, 2019

I think this is important for release. @elfinhe, would you mind taking another look? It's just a matter of sorting all the outputs correctly into stdout and stderr, ping me if you need help.

@elfinhe

This comment has been minimized.

Copy link
Member

@elfinhe elfinhe commented Nov 5, 2019

I think this is important for release. @elfinhe, would you mind taking another look? It's just a matter of sorting all the outputs correctly into stdout and stderr, ping me if you need help.

Sure, I will work on this later today.

@elfinhe elfinhe self-assigned this Nov 5, 2019
@elfinhe

This comment has been minimized.

Copy link
Member

@elfinhe elfinhe commented Nov 6, 2019

@ostromart This is more complicated than I thought. But I can start with manifest generate, profile dump use cases, where --logtostderr is more helpful.

@elfinhe

This comment has been minimized.

Copy link
Member

@elfinhe elfinhe commented Dec 10, 2019

Reopening because when --logtostderr is specified, INFO log still goes into stdout. stdout is mixed with both INFO log and manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.