Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If there is a container that doesn't expose any port, istio-proxy won't start #18594

Closed
jaesquivel opened this issue Nov 4, 2019 · 6 comments · Fixed by #18976
Closed

If there is a container that doesn't expose any port, istio-proxy won't start #18594

jaesquivel opened this issue Nov 4, 2019 · 6 comments · Fixed by #18976
Assignees

Comments

@jaesquivel
Copy link

@jaesquivel jaesquivel commented Nov 4, 2019

If there is a container that doesn't export any port, istio-proxy won't start,

2019-11-04T14:32:36.150148Z error Failed to generate bootstrap config: invalid character ',' looking for beginning of value

Expected behavior
Ignore the container with no network connectivity

Steps to reproduce the bug
Create a POD with two containers, one of them with no ports, istio-proxy won't start and will show an error:
2019-11-04T14:32:36.150148Z error Failed to generate bootstrap config: invalid character ',' looking for beginning of value

Version (include the output of istioctl version --remote and kubectl version)
istioctl version --remote
client version: 1.4.0-beta.0
control plane version: 1.4.0-beta.0
data plane version: 1.4.0-beta.0 (9 proxies)

kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:18:23Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6-eks-5047ed", GitCommit:"5047edce664593832e9b889e447ac75ab104f527", GitTreeState:"clean", BuildDate:"2019-08-21T22:32:40Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
helm

Environment where bug was observed (cloud vendor, OS, etc)
AWS EKS

@howardjohn

This comment has been minimized.

Copy link
Member

@howardjohn howardjohn commented Nov 4, 2019

Can you provide a reproduction? I applied this yaml:

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    app: alpine
  name: alpine
  namespace: default
spec:
  replicas: 1
  selector:
    matchLabels:
      app: alpine
  strategy:
  template:
    metadata:
      labels:
        app: alpine
    spec:
      containers:
      - args:
        - sleep
        - "100000"
        image: alpine
        imagePullPolicy: Always
        name: alpine2
      - args:
        - sleep
        - "10000000000000000"
        image: alpine
        name: alpine
        resources:
          limits:
            cpu: 100m
            memory: 128Mi
          requests:
            cpu: 10m
            memory: 16Mi
@jaesquivel

This comment has been minimized.

Copy link
Author

@jaesquivel jaesquivel commented Nov 11, 2019

@howardjohn

This comment has been minimized.

Copy link
Member

@howardjohn howardjohn commented Nov 11, 2019

Ahh thanks I think I know the issue

@howardjohn howardjohn self-assigned this Nov 11, 2019
@howardjohn

This comment has been minimized.

Copy link
Member

@howardjohn howardjohn commented Nov 11, 2019

in case I get hit by a bus before I fix it - the POD_PORTS variable is doing some shoddy json serialization

howardjohn added a commit to howardjohn/istio that referenced this issue Nov 15, 2019
Fixes istio#18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)
istio-testing added a commit that referenced this issue Nov 22, 2019
Fixes #18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)
sdake added a commit to sdake/istio that referenced this issue Dec 1, 2019
Fixes istio#18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)
@howardjohn

This comment has been minimized.

Copy link
Member

@howardjohn howardjohn commented Dec 3, 2019

Turns out this was not properly backported 😕 it will land in 1.4.3 and 1.3.7 I think, ill send the backports

howardjohn added a commit to howardjohn/istio that referenced this issue Dec 3, 2019
Fixes istio#18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)

(cherry picked from commit d4f9846)
howardjohn added a commit to howardjohn/istio that referenced this issue Dec 3, 2019
Fixes istio#18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)

(cherry picked from commit d4f9846)
istio-testing added a commit that referenced this issue Dec 4, 2019
Fixes #18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)

(cherry picked from commit d4f9846)
@howardjohn

This comment has been minimized.

Copy link
Member

@howardjohn howardjohn commented Dec 10, 2019

this will be in 1.4.3

istio-testing added a commit that referenced this issue Dec 10, 2019
Fixes #18594

Whithout this change, POD_PORTS would have an invalid json like

`[,{port: 123}]` (leading comma)

(cherry picked from commit d4f9846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.