Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicluster secret controller does not handle updates #18708

Closed
ayj opened this issue Nov 6, 2019 · 0 comments
Closed

multicluster secret controller does not handle updates #18708

ayj opened this issue Nov 6, 2019 · 0 comments

Comments

@ayj
Copy link
Contributor

@ayj ayj commented Nov 6, 2019

The multicluster secret controller is used by Pilot and Mixer to watch k8s resources in remote clusters. ADD and DELETE events are handled correctly but there is no handler for UPDATE. This leads to unexpected behavior if, for example, the remote service account changes and the secret needs to be updated. The workaround is delete and re-create the remote cluster's secret.

ayj added a commit to ayj/istio that referenced this issue Mar 5, 2020
The multicluster secret controller was silently ignoring updates to
secrets. Users had to delete and re-add secrets if they wanted to
change the credentials for remote clusters. This PR adds update
support and also improves the unit tests.

fixes istio#18708
ayj added a commit to ayj/istio that referenced this issue Mar 5, 2020
The multicluster secret controller was silently ignoring updates to
secrets. Users had to delete and re-add secrets if they wanted to
change the credentials for remote clusters. This PR adds update
support and also improves the unit tests.

fixes istio#18708
istio-testing added a commit to istio-testing/istio that referenced this issue Mar 5, 2020
The multicluster secret controller was silently ignoring updates to
secrets. Users had to delete and re-add secrets if they wanted to
change the credentials for remote clusters. This PR adds update
support and also improves the unit tests.

fixes istio#18708
@dgn dgn added this to the 1.5 milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.