Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istioctl manifest apply output is confusing with component output #19451

Closed
howardjohn opened this issue Dec 6, 2019 · 3 comments · Fixed by istio/operator#672 or istio/operator#687
Closed
Assignees
Milestone

Comments

@howardjohn
Copy link
Member

@howardjohn howardjohn commented Dec 6, 2019

Preparing manifests for these components:
- NodeAgent
- PrometheusOperator
- CoreDNS
- Galley
- Cni
- EgressGateway
- Citadel
- Telemetry
- Base
- Tracing
- Pilot
- IngressGateway
- Injector
- CertManager
- Prometheus
- Policy
- Grafana
- Kiali

Applying manifest for component Base
Finished applying manifest for component Base
Applying manifest for component Galley
Applying manifest for component Citadel
Applying manifest for component IngressGateway
Applying manifest for component Prometheus
Applying manifest for component Injector
Applying manifest for component Telemetry
Applying manifest for component Pilot
Applying manifest for component Grafana
Finished applying manifest for component IngressGateway
Finished applying manifest for component Citadel
Finished applying manifest for component Galley
Finished applying manifest for component Prometheus
Finished applying manifest for component Injector
Finished applying manifest for component Grafana
Finished applying manifest for component Pilot
Finished applying manifest for component Telemetry

Component NodeAgent installed successfully:
===========================================

Component PrometheusOperator installed successfully:
====================================================

Component CoreDNS installed successfully:
=========================================

Component Galley installed successfully:
========================================

Component Cni installed successfully:
=====================================

Component Citadel installed successfully:
=========================================

Component Telemetry installed successfully:
===========================================

Component Base installed successfully:
======================================

Component Tracing installed successfully:
=========================================

Component Pilot installed successfully:
=======================================

Component EgressGateway installed successfully:
===============================================

Component IngressGateway installed successfully:
================================================

Component Injector installed successfully:
==========================================

Component CertManager installed successfully:
=============================================

Component Prometheus installed successfully:
============================================

Component Policy installed successfully:
========================================

Component Grafana installed successfully:
=========================================

Component Kiali installed successfully:
=======================================

"Preparing manifests for these components:" has a bunch of junk I didn't enabled

The end part also has the same junk I didn't enable

The end part should just look like, we don't need the : =======

Component CertManager installed successfully
Component Prometheus installed successfully
Component Policy installed successfully
Component Grafana installed successfully
Component Kiali installed successfully
@howardjohn

This comment has been minimized.

Copy link
Member Author

@howardjohn howardjohn commented Dec 6, 2019

@elfinhe I think you mentioned you fixed this and it got partially reverted, not sure if its the same

@elfinhe

This comment has been minimized.

Copy link
Member

@elfinhe elfinhe commented Dec 7, 2019

Yes, it is. I reopened that one as well: #18892.

@howardjohn

This comment has been minimized.

Copy link
Member Author

@howardjohn howardjohn commented Dec 10, 2019

This is still not fixed.

Current output:

Preparing manifests for these components:
- Pilot
- Cni
- Policy
- CoreDNS
- Citadel
- Base
- Telemetry
- Prometheus
- EgressGateway
- Kiali
- Galley
- Grafana
- NodeAgent
- Tracing
- IngressGateway
- CertManager
- PrometheusOperator
- Injector

Applying manifest for component Base
Finished applying manifest for component Base
Applying manifest for component Citadel
Applying manifest for component Prometheus
Applying manifest for component Galley
Applying manifest for component Policy
Applying manifest for component IngressGateway
Applying manifest for component Telemetry
Applying manifest for component Pilot
Applying manifest for component Injector
Finished applying manifest for component Citadel
Finished applying manifest for component Prometheus
Finished applying manifest for component IngressGateway
Finished applying manifest for component Pilot
Finished applying manifest for component Galley
Finished applying manifest for component Injector
Finished applying manifest for component Policy
Finished applying manifest for component Telemetry

Component Prometheus - manifest apply finished successfully:
============================================================

Component Galley - manifest apply finished successfully:
========================================================

Component Citadel - manifest apply finished successfully:
=========================================================

Component Base - manifest apply finished successfully:
======================================================

Component Telemetry - manifest apply finished successfully:
===========================================================

Component IngressGateway - manifest apply finished successfully:
================================================================

Component Injector - manifest apply finished successfully:
==========================================================

Component Pilot - manifest apply finished successfully:
=======================================================

Component Policy - manifest apply finished successfully:
========================================================


*** Success ***

Expected output:

Preparing manifests for these components:
- Base
- Citadel
- Pilot
- Telemetry
- Prometheus
- EgressGateway
- Galley
- Grafana
- IngressGateway
- CertManager
- Injector

Applying manifest for component Base
Finished applying manifest for component Base
Applying manifest for component Citadel
Applying manifest for component Prometheus
Applying manifest for component Galley
Applying manifest for component Policy
Applying manifest for component IngressGateway
Applying manifest for component Telemetry
Applying manifest for component Pilot
Applying manifest for component Injector
Finished applying manifest for component Citadel
Finished applying manifest for component Prometheus
Finished applying manifest for component IngressGateway
Finished applying manifest for component Pilot
Finished applying manifest for component Galley
Finished applying manifest for component Injector
Finished applying manifest for component Policy
Finished applying manifest for component Telemetry

Component Prometheus - manifest apply finished successfully
Component Galley - manifest apply finished successfully
Component Citadel - manifest apply finished successfully
Component Base - manifest apply finished successfully
Component Telemetry - manifest apply finished successfully
Component IngressGateway - manifest apply finished successfully
Component Injector - manifest apply finished successfully
Component Pilot - manifest apply finished successfully
Component Policy - manifest apply finished successfully

*** Success ***

The goal here - get rid of the ===== junk, remove components I don't install in the "preparing manifest", and sort output of "preparing manifest".

We can also be consistent with analyze and use checkmark. Also do we even need "preparing components? If we have "finished applying" why do we need the "manifest apply finished successfully".

Really here is my desired output:

- Applying manifest for component Base
✔ Finished applying manifest for component Base
- Applying manifest for component Citadel
- Applying manifest for component Prometheus
- Applying manifest for component Galley
- Applying manifest for component Policy
- Applying manifest for component IngressGateway
- Applying manifest for component Telemetry
- Applying manifest for component Pilot
- Applying manifest for component Injector
✔ Finished applying manifest for component Citadel
✔ Finished applying manifest for component Prometheus
✔ Finished applying manifest for component IngressGateway
✔ Finished applying manifest for component Pilot
✔ Finished applying manifest for component Galley
✔ Finished applying manifest for component Injector
✔ Finished applying manifest for component Policy
✔ Finished applying manifest for component Telemetry

✔ Installation complete

This is the first thing a users sees when they install Istio, so it should be clear and concise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.