Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istioctl --profile merge with -f is broken #19503

Closed
howardjohn opened this issue Dec 10, 2019 · 3 comments
Closed

istioctl --profile merge with -f is broken #19503

howardjohn opened this issue Dec 10, 2019 · 3 comments
Assignees
Milestone

Comments

@howardjohn
Copy link
Member

@howardjohn howardjohn commented Dec 10, 2019

This impacts all known version: I tested 1.4.0, 1.4.2 and master

$ ~/istio/istio-1.4.2/bin/istioctl manifest generate --set profile=minimal | rg istio-telemetry
    mixerReportServer: istio-telemetry.istio-system.svc.cluster.local:9091
$ ~/istio/istio-1.4.2/bin/istioctl manifest generate --set profile=minimal -f <(echo -e'apiVersion: install.istio.io/v1alpha2\nkind: IstioControlPlane')  | rg istio-telemetry
    mixerReportServer: istio-telemetry.istio-system.svc.cluster.local:15004
        regex: istio-telemetry;prometheus
    - job_name: 'istio-telemetry'
        regex: istio-telemetry;http-monitoring
  name: istio-telemetry
    name: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
    app: istio-telemetry
  name: istio-telemetry
    app: istio-telemetry
  host: istio-telemetry.istio-system.svc.cluster.local
                  default_destination_service: istio-telemetry.istio-system.svc.cluster.local
                    istio-telemetry.istio-system.svc.cluster.local:
                            string_value: istio-telemetry.istio-system.svc.cluster.local
                            string_value: istio://istio-system/services/istio-telemetry
                            string_value: istio-telemetry
                  name: istio-telemetry.istio-system.svc.cluster.local
                  default_destination_service: istio-telemetry.istio-system.svc.cluster.local
                    istio-telemetry.istio-system.svc.cluster.local:
                            string_value: istio-telemetry.istio-system.svc.cluster.local
                            string_value: istio://istio-system/services/istio-telemetry
                            string_value: istio-telemetry
                  name: istio-telemetry.istio-system.svc.cluster.local
  name: istio-telemetry
        - istio-telemetry
  name: istio-telemetry
  name: istio-telemetry
    app: istio-telemetry
@howardjohn

This comment has been minimized.

Copy link
Member Author

@howardjohn howardjohn commented Dec 10, 2019

Looks like --set is not broken the same way, but profile+file+set is broken

@ostromart

This comment has been minimized.

Copy link
Contributor

@ostromart ostromart commented Dec 10, 2019

@howardjohn

This comment has been minimized.

Copy link
Member Author

@howardjohn howardjohn commented Dec 11, 2019

fixed

@howardjohn howardjohn closed this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.