Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istioctl manifest exits with code 0 when an error has occurred #19747

Closed
howardjohn opened this issue Dec 23, 2019 · 0 comments · Fixed by istio/operator#721
Closed

istioctl manifest exits with code 0 when an error has occurred #19747

howardjohn opened this issue Dec 23, 2019 · 0 comments · Fixed by istio/operator#721

Comments

@howardjohn
Copy link
Member

@howardjohn howardjohn commented Dec 23, 2019

	if gotError {
		l.logAndPrint("\n\n✘ Errors were logged during apply operation. Please check component installation logs above.\n")
	} else {
		l.logAndPrint("\n\n✔ Installation complete\n")
	}

Code above just logs when there was an error. It should return a non-zero exit code as well. This is especially important for our CI, but also for general purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.