Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.5]IOP instance deletion hangs for In-cluster operator #22280

Closed
morvencao opened this issue Mar 18, 2020 · 2 comments
Closed

[Release-1.5]IOP instance deletion hangs for In-cluster operator #22280

morvencao opened this issue Mar 18, 2020 · 2 comments

Comments

@morvencao
Copy link
Member

@morvencao morvencao commented Mar 18, 2020

Bug description

Build and deploy in-cluster operator from release-1.5 branch, create the IOP instance and make sure everything is working, then delete the IOP instance, found that the deletion is handing there:

# kubectl delete -f operator/deploy/crds/istio_v1alpha1_istiooperator_cr.yaml
istiooperator.install.istio.io "example-istiocontrolplane" deleted

From the operator logs, I can see some field unmarshal error:

2020-03-18T03:19:11.817096Z	error	Error in IstioOperator DeepCopyInto Unmarshal: json: cannot unmarshal string into Go value of type map[string]json.RawMessage

Verified that this is not relevant to the istio/api#1309, I tried to use istio.io/api before that, same error.
In addition, the deletionTimestamp field is added to the IOP instance, looks like some field just break the field unmarshal, looking into this:

# kubectl -n istio-system get iop example-istiocontrolplane -o yaml
apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  creationTimestamp: "2020-03-18T03:17:27Z"
  deletionGracePeriodSeconds: 0
  deletionTimestamp: "2020-03-18T03:18:51Z"
  finalizers:
  - istio-finalizer.install.istio.io
  generation: 2
  name: example-istiocontrolplane
  namespace: istio-system
  resourceVersion: "1412"
  selfLink: /apis/install.istio.io/v1alpha1/namespaces/istio-system/istiooperators/example-istiocontrolplane
  uid: 8d7b96c4-7e5b-456d-8951-bd886c9f86b3
spec:
  profile: demo
status:

[ ] Configuration Infrastructure
[ ] Docs
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Expected behavior

Steps to reproduce the bug

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)

How was Istio installed?

Environment where bug was observed (cloud vendor, OS, etc)

@morvencao

This comment has been minimized.

Copy link
Member Author

@morvencao morvencao commented Mar 18, 2020

This is similar to #18615
Because I found the same field unmarshal error from operator logs:

2020-03-18T03:19:11.817096Z	error	Error in IstioOperator DeepCopyInto Unmarshal: json: cannot unmarshal string into Go value of type map[string]json.RawMessage
@morvencao

This comment has been minimized.

Copy link
Member Author

@morvencao morvencao commented Mar 25, 2020

Fixed in: #22282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.