Fixed incorrect No data in Grafana dashboard panels

[msvticket]

Many panels show No data if Prometheus has a scrape interval configured to be larger than 15s. Using
the $__rate_interval introduced in Grafana 7.2 fixes just that.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[X] Policies and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure

Pull Request Attributes

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

[istio-policy-bot]

😊 Welcome @msvticket! This is either your first contribution to the Istio istio repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[istio-testing]

Hi @msvticket. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[msvticket]

@googlebot I signed it!

[devincd]

/ok-to-test

[howardjohn]

One thing we should look into is how many users are on 7.1 or older. I have no idea currently - could be 1% or 99%

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[shamsher31]

@googlebot I consent

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[douglas-reid]

@howardjohn anything more to review here (i'm just digging through my backlog).

[howardjohn]

I think we need to understand impact of Grafana version requirement

One thing we should look into is how many users are on 7.1 or older. I have no idea currently - could be 1% or 99%

[douglas-reid]

I think we need to understand impact of Grafana version requirement

One thing we should look into is how many users are on 7.1 or older. I have no idea currently - could be 1% or 99%

Do we have any updated insights here?

@msvticket are there ways to achieve the same goal with older primitives?

[msvticket]

I think we need to understand impact of Grafana version requirement

One thing we should look into is how many users are on 7.1 or older. I have no idea currently - could be 1% or 99%

Do we have any updated insights here?

@msvticket are there ways to achieve the same goal with older primitives?

No.

My rationale for it not being that much of a problem to require 7.2 is that if you install Grafana using istio you will as far as I understand currently (master) get version 7.5.5. But it would be good to add some more information also in the other main distribution route for these Dashboards: https://grafana.com/grafana/dashboards

I'm thinking of something along the lines of:

Check revisions to get the dashboard corresponding to your version of istio. Not that from version 1.11.? of istio the Dashboards require Grafana 7.2 or newer.
See https://istio.io/latest/docs/ops/integrations/grafana/ for more details on the integration of istio with Grafana.

[istio-policy-bot]

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2021-08-23. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.