Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude livenessprobe request in rule,fix k8s livenessprobe is unknown in kiali #10480

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@Liv1020
Copy link
Contributor

Liv1020 commented Dec 14, 2018

exclude livenessprobe request in rule,fix k8s livenessprobe is unknown in kiali

#10336

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Dec 14, 2018

Hi @Liv1020. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linsun

linsun approved these changes Dec 18, 2018

Copy link
Member

linsun left a comment

nice fix!

/lgtm

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Dec 18, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linsun, Liv1020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun

This comment has been minimized.

Copy link
Member

linsun commented Dec 18, 2018

/ok-to-test

@istio-testing istio-testing merged commit 0ac85b0 into istio:release-1.1 Dec 18, 2018

31 of 32 checks passed

prow/istio-pilot-multicluster-e2e.sh Job triggered.
Details
GolangCI No issues found!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: e2e-dashboard Your tests passed on CircleCI!
Details
ci/circleci: e2e-galley Your tests passed on CircleCI!
Details
ci/circleci: e2e-mixer-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-auth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-cloudfoundry-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-simple Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: racetest Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-integration-local Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
prow/e2e-bookInfoTests-v1alpha3.sh Job succeeded.
Details
prow/e2e-bookInfoTests.sh Skipped
prow/e2e-dashboard.sh Job succeeded.
Details
prow/e2e-mixer-no_auth.sh Job succeeded.
Details
prow/e2e-simpleTests-cni.sh Skipped
prow/e2e-simpleTests-minProfile.sh Job succeeded.
Details
prow/e2e-simpleTests.sh Job succeeded.
Details
prow/istio-integ-k8s-tests.sh Skipped
prow/istio-integ-local-tests.sh Job succeeded.
Details
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh Job succeeded.
Details
prow/istio-pilot-e2e.sh Skipped
prow/istio-presubmit.sh Job succeeded.
Details
prow/istio-unit-tests.sh Job succeeded.
Details
prow/release-test.sh Job succeeded.
Details
tide In merge pool.
Details

@Liv1020 Liv1020 deleted the Liv1020:fix_kiali branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.