Fix version command to show correct information #14754
Conversation
A recent change made the ldflags not get passed properly leading to the version command giving "unknown". This change fixes this issue, and adds a tests to ensure similar changes are caught in the future. During this it was discovered some of our binaries don't include the version command, so those were added to sdsclient and mixgen.
|
/lgtm |
|
/lgtm |
|
/lgtm |
tests/version/version_test.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
|
|
There was a problem hiding this comment.
File is not gofmt-ed with -s (from gofmt)
|
/test istio_auth_sds_e2e-master |
|
/test integ-mixer-k8s-presubmit-tests-master |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geeknoid, howardjohn, ibm-jason, utka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-bookInfoTests-envoyv2-v1alpha3-master |
|
/test release-test-master |
|
@howardjohn: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
* Fix version command to show correct information A recent change made the ldflags not get passed properly leading to the version command giving "unknown". This change fixes this issue, and adds a tests to ensure similar changes are caught in the future. During this it was discovered some of our binaries don't include the version command, so those were added to sdsclient and mixgen. * Fix lint and codecov * Fix lint (cherry picked from commit 0f775a4) # Conflicts: # bin/gobuild.sh # security/tools/sdsclient/main.go
A recent change made the ldflags not get passed properly leading to the
version command giving "unknown". This change fixes this issue, and adds
a tests to ensure similar changes are caught in the future.
During this it was discovered some of our binaries don't include the
version command, so those were added to sdsclient and mixgen.
Fixes #14745