Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sd adapter go rountine leak #14775

Closed
wants to merge 2 commits into from

Conversation

@bianpengyuan
Copy link
Contributor

commented Jun 13, 2019

k8s addon manager exaggerates this behavior because of the reconciliation, which somehow triggers mixer config watch and keep rebuilding all handlers. I will cherry-pick this into master and 1.2.

@bianpengyuan bianpengyuan requested review from kyessenov and douglas-reid Jun 13, 2019

@googlebot googlebot added the cla: yes label Jun 13, 2019

@istio-testing istio-testing requested a review from mandarjog Jun 13, 2019

@douglas-reid
Copy link
Contributor

left a comment

/lgtm

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh ac4ce4c link /test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

/lgtm
/approve

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianpengyuan, douglas-reid, kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@duderino Can we please merge this? This is a valuable fix for k8s addon and would be nice to have it in 1.1.9. The code is simple and constrained to an individual adapter, so should not introduce much risk.

@howardjohn

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Should we make sure this gets into 1.2 as well? If so we should copy this to master branch

@bianpengyuan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@howardjohn Yes, will do once this is merged. Thanks for reminding!

@howardjohn

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

@bianpengyuan Josh tends to merge PRs into 1.1 right before the release to decide what changes should go in all at once, rather than gradually merging changes then eventually cutting a release. So it may be quicker to cherry pick soon, since we will release 1.2 in the coming days

@bianpengyuan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@howardjohn ack. cherry-pick PR is out: #14803

@stale

This comment has been minimized.

Copy link

commented Jun 27, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Jun 27, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 27, 2019

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@stale stale bot removed the stale label Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.