Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable mixer test (Fix #12750) #14821

Merged
merged 2 commits into from Jul 9, 2019

Conversation

@gargnupur
Copy link
Contributor

commented Jun 13, 2019

Ref: #12750

Based on https://testgrid.k8s.io/istio-postsubmits-master#integ-mixer-k8s-postsubmit-tests&sort-by-flakiness=

  1. TestIngessToPrometheus_ServiceMetric is flaky and should get fixed by refactoring in https://github.com/istio/istio/pull/14111/files#diff-be14bf3bcea83ca5db20fe06f8e4a019. Opened a separate bug to #14819 to track flakiness of tests in this file.
  2. TestCheck_Deny will be fixed by 427ae7c

@gargnupur gargnupur requested a review from ozevren Jun 13, 2019

@googlebot googlebot added the cla: yes label Jun 13, 2019

@istio-testing istio-testing requested review from douglas-reid and geeknoid Jun 13, 2019

@ozevren

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

/lgtm

@ozevren

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

/hold

@ozevren

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Putting a hold here until the other PR goes in. Feel free to remove it once that is done.

@gargnupur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

/test istio-unit-tests-master

@gargnupur gargnupur force-pushed the gargnupur:nup_enable_mixer_test branch from 896924d to f0549e5 Jun 18, 2019

@gargnupur

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

/test integ-mixer-k8s-presubmit-tests-master
/test integ-pilot-k8s-presubmit-tests-master
/test e2e-simpleTests-master

err := util.VisitProductPage(ing, 30*time.Second, 200, t)
if err != nil {
t.Fatalf("unable to retrieve 200 from product page: %v", err)
url := fmt.Sprintf("%s/productpage", ing.HTTPAddress())

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 26, 2019

Contributor

File is not gofmt-ed with -s (from gofmt)

@kyessenov
Copy link
Contributor

left a comment

/lgtm
/approve

gargnupur added some commits Jun 13, 2019

Fix #12750
Make TestIngessToPrometheus_ServiceMetric less flaky by sending
more than 1 productpage request.

Ref: #14819

Make TestTCPMetric more resilient by sending more than 1 request.

Fix fmt

@gargnupur gargnupur force-pushed the gargnupur:nup_enable_mixer_test branch from d652f02 to 59611c3 Jul 8, 2019

@istio-testing istio-testing removed the lgtm label Jul 8, 2019

@kyessenov

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

/lgtm
/approve
after rebase

@istio-testing istio-testing added the lgtm label Jul 8, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gargnupur, kyessenov, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gargnupur

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

/retest

tests look like are stuck...

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/integ-new-installer-k8s-presubmit-tests.sh 59611c3 link /test integ-new-install-k8s-presubmit-tests-master
prow/integ-mixer-k8s-presubmit-tests.sh 59611c3 link /test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 577b608 into istio:master Jul 9, 2019

36 of 38 checks passed

prow/integ-mixer-k8s-presubmit-tests.sh Job failed.
Details
prow/integ-new-installer-k8s-presubmit-tests.sh Job failed.
Details
GolangCI No issues found!
Details
Summary 1 potential rule
Details
ci/circleci: e2e-pilot-cloudfoundry-v1alpha3-v2 Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
istio_e2e_cloudfoundry-master Job succeeded.
Details
prow/codecov.sh Job succeeded.
Details
prow/e2e-bookInfoTests-trustdomain.sh Job succeeded.
Details
prow/e2e-bookInfoTests-v1alpha3.sh Job succeeded.
Details
prow/e2e-dashboard.sh Job succeeded.
Details
prow/e2e-mixer-no_auth.sh Job succeeded.
Details
prow/e2e-pilot-cloudfoundry-v1alpha3-v2.sh Skipped.
prow/e2e-simpleTests.sh Job succeeded.
Details
prow/e2e_pilotv2_auth_sds.sh Job succeeded.
Details
prow/integ-framework-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-framework-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-galley-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-galley-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-istioctl-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-istioctl-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-mixer-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-pilot-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-pilot-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-security-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-security-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-telemetry-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-telemetry-local-presubmit-tests.sh Job succeeded.
Details
prow/istio-integ-k8s-tests.sh Skipped.
prow/istio-integ-local-tests.sh Skipped.
prow/istio-lint.sh Job succeeded.
Details
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh Job succeeded.
Details
prow/istio-pilot-multicluster-e2e.sh Job succeeded.
Details
prow/istio-unit-tests.sh Job succeeded.
Details
prow/racetest.sh Job succeeded.
Details
prow/release-test.sh Job succeeded.
Details
prow/shellcheck.sh Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.