Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate mcp initial requests send and response receive #14831

Closed
wants to merge 4 commits into from

Conversation

4 participants
@hzxuzhonghu
Copy link
Member

commented Jun 14, 2019

fixes: #14829

@googlebot googlebot added the cla: yes label Jun 14, 2019

@hzxuzhonghu hzxuzhonghu requested a review from ayj Jun 14, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ozevren

If they are not already assigned, you can assign the PR to them by writing /assign @ozevren in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing requested a review from ozevren Jun 14, 2019

@hzxuzhonghu

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

/assign @ozevren

@hzxuzhonghu

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

/test integ-framework-local-presubmit-tests-master

@hzxuzhonghu

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

/test e2e-bookInfoTests-envoyv2-v1alpha3-master

@ozevren
Copy link
Member

left a comment

Please add a regression test as well.


sink.journal.RecordRequestResources(req)

if err := stream.Send(req); err != nil {
sink.reporter.RecordSendError(err, status.Code(err))
scope.Errorf("Error sending MCP request: %v", err)
scope.Errorf("Error sending MCP ACK/NCK: %v", err)

This comment has been minimized.

Copy link
@ozevren

ozevren Jun 14, 2019

Member

NCK => NAck

This comment has been minimized.

Copy link
@hzxuzhonghu

hzxuzhonghu Jun 17, 2019

Author Member

NACK?

// send initial requests for each supported type
initialRequests := sink.createInitialRequests()
// send initial subscribe requests
go func() {

This comment has been minimized.

Copy link
@ozevren

ozevren Jun 14, 2019

Member

This changes behavior. If the initial requests cannot be sent, the ProcessStream will still continue executing.

This comment has been minimized.

Copy link
@hzxuzhonghu

hzxuzhonghu Jun 17, 2019

Author Member

I guess you mean this go func error eixt, and the belowing for loop will still run?

I think this can not happen, from my understanding if initial requests cannot be sent, the stream must be broken.

This comment has been minimized.

Copy link
@hzxuzhonghu

hzxuzhonghu Jun 17, 2019

Author Member

Whatever we should separate send and receive in to different routines, as server side does.

hzxuzhonghu added some commits Jun 17, 2019

@hzxuzhonghu hzxuzhonghu force-pushed the hzxuzhonghu:mcp branch from 4caadcb to 34147ed Jun 17, 2019

@stale

This comment has been minimized.

Copy link

commented Jul 1, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Jul 1, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@stale stale bot removed the stale label Jul 1, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jul 1, 2019

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@stale

This comment has been minimized.

Copy link

commented Jul 15, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale label Jul 15, 2019

@hzxuzhonghu hzxuzhonghu deleted the hzxuzhonghu:mcp branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.