Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing separators in CRD files (bp #14844) #14864

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@mergify
Copy link

commented Jun 15, 2019

This is an automated backport of pull request #14844 done by Mergify.io

Fix missing separators in CRD files (#14844)
Some of the workflows people use include `cat` of the CRD files.
While this is not recommended by the devs (instead we should be
recommending kubectl apply -f install/kubernetes/helm/istio-init/files/)
these two CRDs are improperly formatted which could lead to field
failure when operators use workflows not defined in the documentaiton.

Unfortunately our documentation also recommends this workflow here:
https://istio.io/docs/setup/kubernetes/install/multicluster/gateways/

which needs to be addressed separately.

(cherry picked from commit 27a62f6)
@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jun 15, 2019

@istio-testing istio-testing requested review from howardjohn and morvencao Jun 15, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Hi @mergify[bot]. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@morvencao
Copy link
Member

left a comment

/LGTM

@codecov

This comment has been minimized.

Copy link

commented Jun 15, 2019

Codecov Report

Merging #14864 into release-1.2 will increase coverage by 1%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.2   #14864    +/-   ##
=============================================
+ Coverage           77%      77%    +1%     
=============================================
  Files              495      495            
  Lines            48372    48249   -123     
=============================================
+ Hits             36994    36997     +3     
+ Misses            9484     9359   -125     
+ Partials          1894     1893     -1
Impacted Files Coverage Δ
pilot/pkg/serviceregistry/consul/monitor.go 81% <0%> (-4%) ⬇️
galley/testdata/validation/dataset.gen.go 0% <0%> (ø) ⬆️
security/pkg/nodeagent/sds/sdsservice.go 76% <0%> (+3%) ⬆️
@sdake

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

I consent to a merge in 1.2.

@sdake

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

/ok-to-test

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@fpesce

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

CLA: cla bot can't see consent of original author in mergify's PR :P

@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #14864 into release-1.2 will increase coverage by 1%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.2   #14864    +/-   ##
=============================================
+ Coverage           77%      77%    +1%     
=============================================
  Files              495      495            
  Lines            48372    48249   -123     
=============================================
+ Hits             36994    36997     +3     
+ Misses            9484     9359   -125     
+ Partials          1894     1893     -1
Impacted Files Coverage Δ
pilot/pkg/serviceregistry/consul/monitor.go 81% <0%> (-4%) ⬇️
galley/testdata/validation/dataset.gen.go 0% <0%> (ø) ⬆️
security/pkg/nodeagent/sds/sdsservice.go 76% <0%> (+3%) ⬆️
@fpesce

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

/test integ-security-local-presubmit-tests

@linsun

linsun approved these changes Jun 17, 2019

Copy link
Member

left a comment

/lgtm
/approve

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linsun, mergify[bot], morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun merged commit 2b58363 into release-1.2 Jun 17, 2019

51 of 52 checks passed

tide Not mergeable. Job merges-blocked-needs-admin has not succeeded.
Details
GolangCI No issues found!
Details
Summary 1 rule matches
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: e2e-dashboard Your tests passed on CircleCI!
Details
ci/circleci: e2e-galley Your tests passed on CircleCI!
Details
ci/circleci: e2e-mixer-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-auth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-auth-v1alpha3-v2-non-mcp Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-cloudfoundry-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-simple Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: racetest Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
cla/google CLAs have been manually verified by Googler who has set the 'cla: yes' label
codecov/patch Coverage not affected when comparing a9d3b40...152b032
Details
codecov/project 77% (+1%) compared to a9d3b40
Details
prow/e2e-bookInfoTests-trustdomain.sh Job succeeded.
Details
prow/e2e-bookInfoTests-v1alpha3.sh Job succeeded.
Details
prow/e2e-bookInfoTests.sh Skipped
prow/e2e-dashboard.sh Job succeeded.
Details
prow/e2e-mixer-no_auth.sh Job succeeded.
Details
prow/e2e-simpleTests-cni.sh Job succeeded.
Details
prow/e2e-simpleTests-minProfile.sh Job succeeded.
Details
prow/e2e-simpleTests.sh Job succeeded.
Details
prow/e2e_pilotv2_auth_sds.sh Job succeeded.
Details
prow/integ-framework-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-framework-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-galley-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-galley-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-istioctl-k8s-presubmit-tests.sh Skipped
prow/integ-istioctl-local-presubmit-tests.sh Skipped
prow/integ-mixer-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-mixer-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-pilot-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-pilot-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-security-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-security-local-presubmit-tests.sh Skipped
prow/integ-telemetry-k8s-presubmit-tests.sh Skipped
prow/integ-telemetry-local-presubmit-tests.sh Skipped
prow/istio-integ-k8s-tests.sh Skipped
prow/istio-integ-local-tests.sh Skipped
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh Job succeeded.
Details
prow/istio-pilot-e2e.sh Skipped
prow/istio-pilot-multicluster-e2e.sh Job succeeded.
Details
prow/istio-presubmit.sh Job succeeded.
Details
prow/istio-unit-tests.sh Job succeeded.
Details
prow/release-test.sh Job succeeded.
Details
prow: test-e2e-mixer-no_auth Skipped

@mergify mergify bot deleted the mergify/bp/release-1.2/pr-14844 branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.