Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide istioctl upgrade command for RBAC (bp #14849) #14881

Closed
wants to merge 1 commit into from

Conversation

6 participants
@mergify
Copy link

commented Jun 15, 2019

This is an automated backport of pull request #14849 done by Mergify.io

Cherry-pick of 9eab338 has failed:

On branch mergify/bp/release-1.2/pr-14849
Your branch is up to date with 'origin/release-1.2'.

You are currently cherry-picking commit 9eab338ad7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   istioctl/cmd/auth.go

no changes added to commit (use "git add" and/or "git commit -a")

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

Hide istioctl upgrade command for RBAC (#14849)
(cherry picked from commit 9eab338)

# Conflicts:
#	istioctl/cmd/auth.go
@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mergify[bot]
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: esnible

If they are not already assigned, you can assign the PR to them by writing /assign @esnible in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

Hi @mergify[bot]. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -90,8 +90,14 @@ THIS COMMAND IS STILL UNDER ACTIVE DEVELOPMENT AND NOT READY FOR PRODUCTION USE.
}

upgradeCmd = &cobra.Command{
<<<<<<< HEAD

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 15, 2019

Contributor

expected operand, found '<<' (from typecheck)

Hidden: true,
Use: "upgrade",
Short: "Upgrade Istio Authorization Policy from version v1 to v2",
>>>>>>> 9eab338ad7... Hide istioctl upgrade command for RBAC (#14849)

This comment has been minimized.

Copy link
@golangcibot

golangcibot Jun 15, 2019

Contributor

illegal floating-point exponent (from typecheck)

@codecov

This comment has been minimized.

Copy link

commented Jun 15, 2019

Codecov Report

Merging #14881 into release-1.2 will increase coverage by 1%.
The diff coverage is 82%.

@@              Coverage Diff              @@
##           release-1.2   #14881    +/-   ##
=============================================
+ Coverage           77%      77%    +1%     
=============================================
  Files              495      498     +3     
  Lines            48383    49060   +677     
=============================================
+ Hits             37002    37677   +675     
+ Misses            9486     9423    -63     
- Partials          1895     1960    +65
Impacted Files Coverage Δ
mixer/pkg/lang/cel/provider.go 75% <ø> (ø) ⬆️
mixer/adapter/kubernetesenv/kubernetesenv.go 90% <ø> (ø) ⬆️
mixer/pkg/il/types.go 100% <ø> (+19%) ⬆️
mixer/pkg/server/interceptor.go 89% <ø> (ø) ⬆️
galley/testdata/validation/dataset.gen.go 69% <ø> (+69%) ⬆️
mixer/pkg/runtime/lang/lang.go 69% <ø> (ø) ⬆️
mixer/pkg/protobuf/yaml/dynamic/auth.go 83% <ø> (ø) ⬆️
istioctl/cmd/register.go 37% <0%> (ø) ⬆️
istioctl/pkg/kubernetes/client.go 0% <0%> (ø) ⬆️
istioctl/cmd/deregister.go 0% <0%> (ø) ⬆️
... and 75 more
@sdake

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

/ok-to-test

@sdake
Copy link
Member

left a comment

merge error, would be nice if mergify notated this requires a manual backport.

@sdake

This comment has been minimized.

Copy link
Member

commented Jun 15, 2019

I guess it does notate it failed... Sort of hard to see :)

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 15, 2019

@mergify[bot]: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/release-test.sh 27a6376 link /test release-test-release-1.2
prow/istio-unit-tests.sh 27a6376 link /test istio-unit-tests-release-1.2
prow/istio-presubmit.sh 27a6376 link /test istio-presubmit-release-1.2
prow/e2e-mixer-no_auth.sh 27a6376 link /test e2e-mixer-no_auth-release-1.2
prow/e2e-dashboard.sh 27a6376 link /test e2e-dashboard-release-1.2
prow/e2e-bookInfoTests-v1alpha3.sh 27a6376 link /test e2e-bookInfoTests-envoyv2-v1alpha3-release-1.2
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh 27a6376 link /test istio-pilot-e2e-envoyv2-v1alpha3-release-1.2
prow/e2e-bookInfoTests-trustdomain.sh 27a6376 link /test e2e-bookInfoTests-trustdomain-release-1.2
prow/e2e-simpleTests.sh 27a6376 link /test e2e-simpleTests-release-1.2
prow/e2e_pilotv2_auth_sds.sh 27a6376 link /test istio_auth_sds_e2e-release-1.2
prow/istio-pilot-multicluster-e2e.sh 27a6376 link /test istio-pilot-multicluster-e2e-release-1.2
prow/integ-galley-k8s-presubmit-tests.sh 27a6376 link /test integ-galley-k8s-presubmit-tests-release-1.2
prow/integ-framework-k8s-presubmit-tests.sh 27a6376 link /test integ-framework-k8s-presubmit-tests-release-1.2
prow/integ-mixer-k8s-presubmit-tests.sh 27a6376 link /test integ-mixer-k8s-presubmit-tests-release-1.2
prow/integ-pilot-k8s-presubmit-tests.sh 27a6376 link /test integ-pilot-k8s-presubmit-tests-release-1.2
prow/integ-security-k8s-presubmit-tests.sh 27a6376 link /test integ-security-k8s-presubmit-tests-release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fpesce

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@pitlv2109 Please manually cherrypick your #14849 change, as the automatic cherry pick by mergify failed for this.

@fpesce fpesce closed this Jun 17, 2019

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@mergify mergify bot deleted the mergify/bp/release-1.2/pr-14849 branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.