Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused value 'istioNamespace' when fill app template #14896

Merged
merged 1 commit into from Jun 17, 2019

Conversation

4 participants
@ChangyuWang
Copy link
Contributor

commented Jun 16, 2019

When run e2e pilot_test, the template value 'istioNamespace' is unused in the step of filling app template

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 16, 2019

Hi @ChangyuWang. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

/ok-to-test
/lgtm

@istio-testing

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChangyuWang, howardjohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 4d5a0c3 into istio:master Jun 17, 2019

47 of 49 checks passed

prow/integ-security-k8s-presubmit-tests.sh Job triggered.
Details
prow/istio-pilot-multicluster-e2e.sh Job triggered.
Details
GolangCI No issues found!
Details
Summary 1 potential rule
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: e2e-dashboard Your tests passed on CircleCI!
Details
ci/circleci: e2e-mixer-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-auth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-auth-v1alpha3-v2-non-mcp Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-cloudfoundry-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-simple Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: racetest Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
prow/e2e-bookInfoTests-trustdomain.sh Job succeeded.
Details
prow/e2e-bookInfoTests-v1alpha3.sh Job succeeded.
Details
prow/e2e-bookInfoTests.sh Skipped
prow/e2e-dashboard.sh Job succeeded.
Details
prow/e2e-mixer-no_auth.sh Job succeeded.
Details
prow/e2e-simpleTests-cni.sh Skipped
prow/e2e-simpleTests-minProfile.sh Skipped
prow/e2e-simpleTests.sh Job succeeded.
Details
prow/e2e_pilotv2_auth_sds.sh Job succeeded.
Details
prow/integ-framework-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-framework-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-galley-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-galley-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-istioctl-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-istioctl-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-mixer-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-mixer-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-pilot-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-pilot-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-security-local-presubmit-tests.sh Job succeeded.
Details
prow/integ-telemetry-k8s-presubmit-tests.sh Job succeeded.
Details
prow/integ-telemetry-local-presubmit-tests.sh Job succeeded.
Details
prow/istio-integ-k8s-tests.sh Skipped
prow/istio-integ-local-tests.sh Skipped
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh Job succeeded.
Details
prow/istio-pilot-e2e.sh Skipped
prow/istio-presubmit.sh Skipped
prow/istio-unit-tests.sh Job succeeded.
Details
prow/release-test.sh Job succeeded.
Details
prow: test-e2e-mixer-no_auth Skipped
tide In merge pool.
Details

@ChangyuWang ChangyuWang deleted the ChangyuWang:e2e-pilot-app branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.