Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send partial update on scale to zero endpoints #17957

Merged

Conversation

@howardjohn
Copy link
Member

howardjohn commented Oct 17, 2019

#16967 introduced a change to do a
full push on scale to zero, but actually I think we can do a partial
push, so we just send an empty EDS set.

I am concerned about a case where a pod is flapping between ready/not
ready and sending tons of full push events. Now this will only send EDS
push.

[x] Networking

#16967 introduced a change to do a
full push on scale to zero, but actually I think we can do a partial
push, so we just send an empty EDS set.

I am concerned about a case where a pod is flapping between ready/not
ready and sending tons of full push events. Now this will only send EDS
push.
@howardjohn howardjohn requested a review from XanderStrike Oct 17, 2019
@howardjohn howardjohn requested a review from istio/wg-networking-maintainers-pilot as a code owner Oct 17, 2019
@googlebot googlebot added the cla: yes label Oct 17, 2019
howardjohn added a commit to howardjohn/istio that referenced this pull request Oct 17, 2019
@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Oct 17, 2019

@howardjohn: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integ-mixer-k8s-tests_istio b5e346d link /test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit 759684c into istio:master Oct 17, 2019
28 of 29 checks passed
28 of 29 checks passed
integ-mixer-k8s-tests_istio Job failed.
Details
cla/google All necessary CLAs are signed
e2e-bookInfoTests-envoyv2-v1alpha3_istio Job succeeded.
Details
e2e-dashboard_istio Job succeeded.
Details
e2e-mixer-no_auth_istio Job succeeded.
Details
e2e-simpleTests-cni_istio Job succeeded.
Details
e2e-simpleTests-distroless_istio Job succeeded.
Details
e2e-simpleTestsMinProfile_istio Job succeeded.
Details
e2e-simpleTests_istio Job succeeded.
Details
gencheck_istio Job succeeded.
Details
integ-framework-k8s-tests_istio Job succeeded.
Details
integ-framework-local-tests_istio Job succeeded.
Details
integ-galley-k8s-tests_istio Job succeeded.
Details
integ-galley-local-tests_istio Job succeeded.
Details
integ-istioctl-k8s-tests_istio Job succeeded.
Details
integ-istioio-k8s-tests_istio Job succeeded.
Details
integ-new-install-k8s-tests_istio Job succeeded.
Details
integ-pilot-k8s-tests_istio Job succeeded.
Details
integ-pilot-local-tests_istio Job succeeded.
Details
integ-security-k8s-tests_istio Job succeeded.
Details
integ-security-local-tests_istio Job succeeded.
Details
integ-telemetry-k8s-tests_istio Job succeeded.
Details
istio_e2e_cloudfoundry_istio Job succeeded.
Details
lint_istio Job succeeded.
Details
pilot-e2e-envoyv2-v1alpha3_istio Job succeeded.
Details
pilot-multicluster-e2e_istio Job succeeded.
Details
release-test_istio Job succeeded.
Details
tide In merge pool.
Details
unit-tests_istio Job succeeded.
Details
fpesce added a commit that referenced this pull request Oct 17, 2019
…17958)

* Cherrypick: Send partial update on scale to zero endpoints

This is a cherrypick of #17957 and
https://github.com/istio/istio/pull/16967/files to the release 1.2
branch.

* Backport adsc race condition fixes

* Move inside if

* Revert "Backport adsc race condition fixes"

This reverts commit a6f6397.
howardjohn added a commit to howardjohn/istio that referenced this pull request Oct 28, 2019
istio#16967 introduced a change to do a
full push on scale to zero, but actually I think we can do a partial
push, so we just send an empty EDS set.

I am concerned about a case where a pod is flapping between ready/not
ready and sending tons of full push events. Now this will only send EDS
push.

(cherry picked from commit 759684c)
istio-testing added a commit that referenced this pull request Nov 6, 2019
* send full update when a service is found to have no endpoints (#16967)

otherwise these endpoints will never be culled from sidecars

(cherry picked from commit d932390)

* Send partial update on scale to zero endpoints (#17957)

#16967 introduced a change to do a
full push on scale to zero, but actually I think we can do a partial
push, so we just send an empty EDS set.

I am concerned about a case where a pod is flapping between ready/not
ready and sending tons of full push events. Now this will only send EDS
push.

(cherry picked from commit 759684c)

* Fix lint
@howardjohn

This comment has been minimized.

Copy link
Member Author

howardjohn commented Jan 12, 2020

/cherrypick release-1.4

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Jan 12, 2020

@howardjohn: new pull request created: #20109

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.