Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodeagent/sdsagent CSR backoff config and algorithm. #20530

Merged
merged 3 commits into from Jan 27, 2020

Conversation

@myidpt
Copy link
Contributor

myidpt commented Jan 25, 2020

The default inital backoff (jitter) for nodeagent/sdsagent to send out CSR is set to [0, 2) sec. The total timeout for multiple CSR retries is set to 10 sec. Node agent does exponential backoff on the retries.
This setup adjustment is needed to align with remote CA SLOs such as Google CA.

@myidpt myidpt requested review from howardjohn and JimmyCYJ Jan 25, 2020
@myidpt myidpt requested review from istio/wg-networking-maintainers as code owners Jan 25, 2020
@googlebot googlebot added the cla: yes label Jan 25, 2020
@myidpt myidpt requested a review from lei-tang Jan 27, 2020
@myidpt myidpt removed the request for review from lei-tang Jan 27, 2020
@istio-testing istio-testing merged commit 492696d into istio:master Jan 27, 2020
23 checks passed
23 checks passed
cla/google All necessary CLAs are signed
e2e-bookInfoTests-envoyv2-v1alpha3_istio Job succeeded.
Details
e2e-dashboard_istio Job succeeded.
Details
e2e-mixer-no_auth_istio Job succeeded.
Details
gencheck_istio Job succeeded.
Details
integ-conformance-k8s-tests_istio Job succeeded.
Details
integ-conformance-local-tests_istio Job succeeded.
Details
integ-distroless-k8s-tests_istio Job succeeded.
Details
integ-galley-k8s-tests_istio Job succeeded.
Details
integ-galley-local-tests_istio Job succeeded.
Details
integ-istioio-k8s-tests_istio Job succeeded.
Details
integ-mixer-k8s-tests_istio Job succeeded.
Details
integ-pilot-k8s-tests_istio Job succeeded.
Details
integ-pilot-local-tests_istio Job succeeded.
Details
integ-security-k8s-tests_istio Job succeeded.
Details
integ-security-local-tests_istio Job succeeded.
Details
integ-telemetry-k8s-tests_istio Job succeeded.
Details
lint_istio Job succeeded.
Details
pilot-e2e-envoyv2-v1alpha3_istio Job succeeded.
Details
pilot-multicluster-e2e_istio Job succeeded.
Details
release-test_istio Job succeeded.
Details
tide In merge pool.
Details
unit-tests_istio Job succeeded.
Details
@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Jan 27, 2020

In response to a cherrypick label: new pull request created: #20565

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Jan 27, 2020

In response to a cherrypick label: #20530 failed to apply on top of branch "release-1.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
A	pkg/istio-agent/sds-agent.go
M	security/pkg/nodeagent/cache/secretcache.go
M	security/pkg/nodeagent/cache/secretcache_test.go
Falling back to patching base and 3-way merge...
Auto-merging security/pkg/nodeagent/cache/secretcache_test.go
CONFLICT (content): Merge conflict in security/pkg/nodeagent/cache/secretcache_test.go
Auto-merging security/pkg/nodeagent/cache/secretcache.go
CONFLICT (content): Merge conflict in security/pkg/nodeagent/cache/secretcache.go
CONFLICT (modify/delete): pkg/istio-agent/sds-agent.go deleted in HEAD and modified in Update nodeagent SDS backoff config and algorithm.. Version Update nodeagent SDS backoff config and algorithm. of pkg/istio-agent/sds-agent.go left in tree.
Patch failed at 0001 Update nodeagent SDS backoff config and algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.