Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve analyzer message code IST0119 for policy with jwt message #20767

Conversation

@jacob-delgado
Copy link
Contributor

jacob-delgado commented Feb 1, 2020

Cherry-pick the commit aimed for master/release-1.5 branch that will
contain the error message to be used for the release-1.4 branch.

Regenerate the messages.gen.go file based on the messsage created
(remove comments suggesting it was deprecatfor the release-1.4 branch.

This is step 2 to get this merged into release 1.4 based on the plan outlined at #20672 (comment).

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Feb 1, 2020

Hi @jacob-delgado. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The code to use this analyzer will follow after this has been merged
into master and the release-1.5 branch. This is so that we can track
this commit individually since there will also be an analyzer for istio
1.4 that utilizes this code.
@jacob-delgado jacob-delgado force-pushed the jacob-delgado:add-message-jwt-policy-cherry-pick-14 branch from efbf594 to 1f6eb70 Feb 1, 2020
@ericvn

This comment has been minimized.

Copy link
Contributor

ericvn commented Feb 3, 2020

/ok-to-test

@jacob-delgado

This comment has been minimized.

Copy link
Contributor Author

jacob-delgado commented Feb 3, 2020

#20671 was merged into master

@jacob-delgado jacob-delgado marked this pull request as ready for review Feb 3, 2020
@jacob-delgado jacob-delgado requested a review from istio/release-managers-1-4 as a code owner Feb 3, 2020
@jacob-delgado

This comment has been minimized.

Copy link
Contributor Author

jacob-delgado commented Feb 5, 2020

@ayj Can you approve this message? Whom do I need to contact after your approval?

@ayj
ayj approved these changes Feb 5, 2020
@ayj

This comment has been minimized.

Copy link
Contributor

ayj commented Feb 5, 2020

Whom do I need to contact after your approval?

@istio/release-managers-1-4

@istio-testing istio-testing merged commit 2366699 into istio:release-1.4 Feb 5, 2020
28 of 29 checks passed
28 of 29 checks passed
tide Not mergeable.
Details
cla/google All necessary CLAs are signed
e2e-bookInfoTests-envoyv2-v1alpha3_istio_release-1.4 Job succeeded.
Details
e2e-dashboard_istio_release-1.4 Job succeeded.
Details
e2e-mixer-no_auth_istio_release-1.4 Job succeeded.
Details
e2e-simpleTests-cni_istio_release-1.4 Job succeeded.
Details
e2e-simpleTests-distroless_istio_release-1.4 Job succeeded.
Details
e2e-simpleTestsMinProfile_istio_release-1.4 Job succeeded.
Details
e2e-simpleTests_istio_release-1.4 Job succeeded.
Details
gencheck_istio_release-1.4 Job succeeded.
Details
integ-framework-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-framework-local-tests_istio_release-1.4 Job succeeded.
Details
integ-galley-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-galley-local-tests_istio_release-1.4 Job succeeded.
Details
integ-istioctl-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-istioio-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-mixer-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-new-install-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-pilot-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-pilot-local-tests_istio_release-1.4 Job succeeded.
Details
integ-security-k8s-tests_istio_release-1.4 Job succeeded.
Details
integ-security-local-tests_istio_release-1.4 Job succeeded.
Details
integ-telemetry-k8s-tests_istio_release-1.4 Job succeeded.
Details
istio_e2e_cloudfoundry_istio_release-1.4 Job succeeded.
Details
lint_istio_release-1.4 Job succeeded.
Details
pilot-e2e-envoyv2-v1alpha3_istio_release-1.4 Job succeeded.
Details
pilot-multicluster-e2e_istio_release-1.4 Job succeeded.
Details
release-test_istio_release-1.4 Job succeeded.
Details
unit-tests_istio_release-1.4 Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.