Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove health plugin and management cluster #24361

Merged
merged 4 commits into from Jun 4, 2020
Merged

Remove health plugin and management cluster #24361

merged 4 commits into from Jun 4, 2020

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Jun 3, 2020 •
edited

These are no longer relevant. All "management" traffic is bypassed in iptables setup because we have the probe rewrite

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 3, 2020
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jun 3, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 3, 2020
@istio-testing
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn
Copy link
Member Author

/test all

@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2020
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 3, 2020
@howardjohn
Copy link
Member Author

/test all

@howardjohn howardjohn marked this pull request as ready for review June 3, 2020 18:20
@howardjohn howardjohn requested review from a team as code owners June 3, 2020 18:20
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 3, 2020
douglas-reid
douglas-reid approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for p&t ownership parts.

@howardjohn
Copy link
Member Author

/retest

@howardjohn howardjohn mentioned this pull request Jun 3, 2020
Merged
@howardjohn
Copy link
Member Author

cc @incfly

@howardjohn howardjohn added the do-not-merge/hold Block automatic merging of a PR. label Jun 3, 2020
@howardjohn
Copy link
Member Author

Put a hold on to double check with some others that this won't break other things

@howardjohn howardjohn removed the do-not-merge/hold Block automatic merging of a PR. label Jun 4, 2020
@incfly
Copy link

incfly commented Jun 4, 2020

/lgtm

apps health check would not impact by this as long as you are not changing iptables.

@istio-testing istio-testing merged commit 19c8e17 into istio:master Jun 4, 2020
nschhina pushed a commit to nschhina/istio that referenced this pull request Jun 18, 2020
@howardjohn @nschhina
Remove health plugin and management cluster (istio#24361)
10a3f8d 
* Remove health plugin

* remove mgmt cluster

* Fully cleanup

* More cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshriram rshriram rshriram approved these changes

@nrjpoddar nrjpoddar nrjpoddar approved these changes

@douglas-reid douglas-reid douglas-reid approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@howardjohn @istio-testing @incfly @rshriram @nrjpoddar @douglas-reid @googlebot