Skip to content

optimize memory usage (#25531) - #25532

Merged
istio-testing merged 1 commit into
istio:masterfrom
dozer47528:master
Jul 15, 2020
Merged

optimize memory usage (#25531)#25532
istio-testing merged 1 commit into
istio:masterfrom
dozer47528:master

Conversation

@dozer47528

@dozer47528 dozer47528 commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

Use ConfigKey for map keys will waste too much memory.

Before Optimize:

image

After Optimize

image

[x] Performance and Scalability

@dozer47528
dozer47528 requested a review from a team as a code owner July 15, 2020 09:52
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 15, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 15, 2020
@istio-testing

istio-testing commented Jul 15, 2020

Copy link
Copy Markdown
Collaborator

Hi @dozer47528. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dozer47528 dozer47528 mentioned this pull request Jul 15, 2020
Closed
@ramaraochavali

ramaraochavali commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 15, 2020
@ramaraochavali

ramaraochavali commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

lgtm. Will leave it open for others review

@howardjohn

howardjohn commented Jul 15, 2020

Copy link
Copy Markdown
Member

/test benchmark_istio

@istio-testing
istio-testing merged commit ec9166a into istio:master Jul 15, 2020
@knight42

knight42 commented Jul 15, 2020

Copy link
Copy Markdown
Member

I am a bit concerned that what if the hash code of two ConfigKeys happended to be the same? would SidecarScope. DependsOnConfig() report false positive?

@howardjohn

howardjohn commented Jul 15, 2020 via email

Copy link
Copy Markdown
Member

williamaronli added a commit to williamaronli/istio that referenced this pull request Jul 15, 2020
@williamaronli
Merge commit 'adeffcf1db154d207bbcd5fa6a13019702f64721' into test07/15
fd46786 
* commit 'adeffcf1db154d207bbcd5fa6a13019702f64721':
  Optimize DR lookup in EDS (istio#25518)
  XDS-based replacement for /debug/syncz (istio#25344)
  Azure Platform Support (istio#24995)
  Automator: update common-files@master in istio/istio@master (istio#25547)
  Use MARKDOWN_LINT_ALLOWLIST instead of _WHITELIST (istio#25545)
  optimize memory usage (istio#25531) (istio#25532)
  refactor pod lookup code (istio#25524)
  Automator: update common-files@master in istio/istio@master (istio#25540)
  disable enforcing successrate based outlier detection (istio#25534)
  minor ads renaming (istio#25537)
  Remove RequireCerts from SDS Agent (istio#25458)
  For k8s registry the instance handler is redudant (istio#25462)
  namespace controller: use shared informer (istio#25123)
  Run generate tests also through istioctl install and operator (istio#25254)
@ramaraochavali ramaraochavali mentioned this pull request Jul 17, 2020
Closed
@howardjohn howardjohn mentioned this pull request Aug 3, 2020
Closed
@howardjohn

howardjohn commented Oct 28, 2020

Copy link
Copy Markdown
Member

/cherrypick release-1.6

@istio-testing

istio-testing commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

@howardjohn: #25532 failed to apply on top of branch "release-1.6":

Applying: optimize memory usage (#25531)
Using index info to reconstruct a base tree...
M	pilot/pkg/model/config.go
M	pilot/pkg/model/sidecar.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/model/sidecar.go
CONFLICT (content): Merge conflict in pilot/pkg/model/sidecar.go
Auto-merging pilot/pkg/model/config.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 optimize memory usage (#25531)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing

istio-testing commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

@howardjohn: new issue created for failed cherrypick: #28368

Details

In response to this:

/cherrypick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing mentioned this pull request Oct 28, 2020
Closed
howardjohn pushed a commit to howardjohn/istio that referenced this pull request Oct 28, 2020
Dozer @howardjohn
optimize memory usage (istio#25531) (istio#25532)
e7b6d4f 
(cherry picked from commit ec9166a)
istio-testing pushed a commit that referenced this pull request Oct 29, 2020
@howardjohn Dozer
optimize memory usage (#25531) (#25532) (#28369)
ad98f02 
(cherry picked from commit ec9166a)

Co-authored-by: Dozer <mail@dozer.cc>
@ramaraochavali ramaraochavali mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dozer47528 @istio-testing @ramaraochavali @howardjohn @knight42 @googlebot