Conditionally keep inbound listeners - #28111
Merged
istio-testing merged 1 commit intoOct 21, 2020
Merged
Conversation
google-cla
Bot
added
the
cla: yes
istio-testing
added
the
size/S
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
lambdai
approved these changes
Oct 21, 2020
lambdai
left a comment
lambdai
left a comment
Contributor
There was a problem hiding this comment.
LGTM
The root of the cause is an ancient bug in istio-iptables.
Unless we dispatch configs depends on an option `doesIstioIptablesHaveThatBug", there is no way to upgrade.
Contributor
|
Fix my comment: Or 2 step upgrade |
ramaraochavali
approved these changes
Oct 21, 2020
jacob-delgado
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28026
This PR is for 1.6 only, as it is intended only for in place upgrade between certain 1.5 -> 1.6 upgrade paths. This change has no impact by default to minimize potentially high impact changes so late into the 1.6 release