add retry conditions to existing virtual service tests #33821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-policy-bot
added
area/networking
release-notes-none
google-cla
bot
added
the
cla: yes
istio-testing
added
the
size/XS
howardjohn
reviewed
Jul 7, 2021
| }) | ||
| var cases []TrafficTestCase | ||
| cases = append(cases, | ||
| // Retry conditions have been added to just validate that config is correct. |
There was a problem hiding this comment.
should we just add another case? This makes the "Added header" one more complicate
There was a problem hiding this comment.
Yes. Thanks. as usual your idea makes lot of sense :-). Moved.
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
size/S
howardjohn
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds retry conditions to existing virtual service to validate that config is not rejected by Envoy.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.