Migrate to google.golang.org/protobuf

[howardjohn]

Fixes #31666

This pr was WAY bigger than I expected.

It mostly consists of:

• Boilerplate replacing imports/function names
• Fixing instances where we mixed golang/protobuf and gogo/protobuf, which are now entirely incompatible
• jsonpb changed a bit, both in the call signature and now the output is not deterministic so where we care we need to use caution
• In istioctl we had some hacks to allow unknown Any which required copying some internal code from proto library into our own
• Bumping cncf/xds and cncf/udpa libraries which had some breakages with importing a newer library

Benchmarks show no difference in perf

[jacob-delgado]

Is the plan to also change istio/api too? Should we wait until we branch for 1.12? Simple enough change so I'm thinking we should if possible.

[howardjohn]

istio/api uses gogo protobuf which is effectively a different incompatible ecosystem. This is just changing golang protobuf usage to the newer version. The old version is basically a layer on top of this one so aside from the function signatures the actual code is largely unchanged. I do think we should move istio/api, and this helps us get there in some ways, but it's largely orthogonal effort. and its less straightforward since it's not backwards compatible, has perf implications, bike shedding,etc. So I would definitely decouple it from this. This one is big enough anyways. As for 1.12 - I would slightly prefer it's in to make backports simpler but it doesn't really matter

…

On Mon, Oct 18, 2021, 6:37 PM jacob-delgado ***@***.***> wrote: Is the plan to also change istio/api too? Should we wait until we branch for 1.12? Simple enough change so I'm thinking we should if possible. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35659 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYGXPPFWMEG5XYVGJNIGDUHTDXFANCNFSM5GH3EIEA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[douglas-reid]

approving for files owned by e&t

[howardjohn]

Blocked by golang/protobuf#1374

[lei-tang]

Approve for security related changes.