New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase health probe interval #6610

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
5 participants
@ostromart
Copy link
Contributor

ostromart commented Jun 25, 2018

Health check file write interval is currently the same as the probe interval (2s). If the probe happens to be closely aligned with the write, this could lead to failures due to small delays in the write.
This PR increases the probe interval to give enough buffer to avoid this.
It could be the cause for #6553 and/or istio/old_issues_repo#383

@istio-testing istio-testing requested review from ayj , gyliu513 and ozevren Jun 25, 2018

@googlebot googlebot added the cla: yes label Jun 25, 2018

@ayj

ayj approved these changes Jun 25, 2018

Copy link
Contributor

ayj left a comment

/lgtm

@gyliu513
Copy link
Member

gyliu513 left a comment

/lgtm

@istio-testing

This comment has been minimized.

Copy link
Collaborator

istio-testing commented Jun 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayj, gyliu513, ostromart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit ae1a963 into istio:master Jun 26, 2018

19 of 20 checks passed

ci/circleci: racetest Your tests failed on CircleCI
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: e2e-galley Your tests passed on CircleCI!
Details
ci/circleci: e2e-mixer-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-auth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-cloudfoundry-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-pilot-noauth-v1alpha3-v2 Your tests passed on CircleCI!
Details
ci/circleci: e2e-simple Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
prow/e2e-bookInfoTests-v1alpha3.sh Job succeeded.
Details
prow/e2e-dashboard.sh Job succeeded.
Details
prow/e2e-mixer-no_auth.sh Job succeeded.
Details
prow/e2e-simpleTests.sh Job succeeded.
Details
prow/istio-pilot-e2e-envoyv2-v1alpha3.sh Job succeeded.
Details
prow/istio-presubmit.sh Job succeeded.
Details
prow/istio-unit-tests.sh Job succeeded.
Details
tide In merge pool.
Details

@ostromart ostromart deleted the ostromart:webhook_healthcheck branch Jun 26, 2018

quanjielin added a commit to quanjielin/istio that referenced this pull request Jul 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment