Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Support multiple network interfaces(#9441) #9688
@@ Coverage Diff @@ ## release-1.1 #9688 +/- ## ============================================== + Coverage 63% 70% +8% ============================================== Files 565 436 -129 Lines 52255 40566 -11689 ============================================== - Hits 32519 28321 -4198 + Misses 17872 10893 -6979 + Partials 1864 1352 -512
Lets please not start creating ad-hoc metadata variables that control pilot behavior. If someone creates yet another ISTIO_META_NODE_IPs, there is no way to spot the collision or the ensuing confusion.
I would like to see some use case for this first.
@rshriram These test failures seem not relevant to my PR, should I look into them?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Dec 11, 2018
@zhaohuabing: The following test failed, say