Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Make versions.yaml also compiled-in #395

Merged
merged 1 commit into from Oct 17, 2019

Conversation

ostromart
Copy link
Contributor

@ostromart ostromart commented Oct 16, 2019

Also removing some lingering versions related info which is unused and just causes confusion.

@ostromart ostromart requested a review from a team as a code owner October 16, 2019 21:57
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 16, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 16, 2019
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2019
@istio-testing
Copy link

@ostromart: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
gencheck_operator b54fe6d link /test gencheck_operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@elfinhe elfinhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

data/versions.yaml Show resolved Hide resolved
@istio-testing istio-testing merged commit c92120c into istio:master Oct 17, 2019
@ostromart
Copy link
Contributor Author

/cherrypick release-1.4

@istio-testing
Copy link

@ostromart: new pull request created: #409

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants